Undo ControlPanel: Creates an @transactions endpoint by fetching transactions from the database

[MdSahil-oss]

No description provided.

[mister-roboto]

@MdSahil-oss thanks for creating this Pull Request and helping to improve Plone!

TL;DR: Finish pushing changes, pass all other checks, then paste a comment:

@jenkins-plone-org please run jobs

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically.

Happy hacking!

[netlify]

✅ Deploy Preview for plone-restapi ready!

Name	Link
🔨 Latest commit	3d0be21
🔍 Latest deploy log	https://app.netlify.com/sites/plone-restapi/deploys/6333d5fa76d694000b199e13
😎 Deploy Preview	https://deploy-preview-1455--plone-restapi.netlify.app/endpoints/transactions.html
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site settings.

[jensens]

Was this tested with a history free RelStorage? (In this case the whole endpoint is pointless)

[robgietema]

What is missing are the tests for the calls. I also added some minor change requests, mostly naming and language.

[MdSahil-oss]

@jensens Yes! This was tested for the RelStorage.
Once the database is created a few transactions are stored in RelStorage like initial Database creation, Created initial User, etc so I think there is no Error message is generated by the Database for Empty Transactions on calling @Transactions endpoint because transactions Array in not null ever.

Here I'm showing A list of few transactions that automatically created by Zope Once database is created.

[jensens]

This is an excerpt from my working configuration using a Postgresql:

...

[instance]
eggs =
    Plone
    RelStorage[postgresql]

rel-storage =
    type postgresql
    dsn dbname='${db:name}' host='${db:host}' user='${db:user}' password='${db:password}'
    keep-history false
    shared-blob-dir true
    blob-dir ${db:blob-dir}
    
[db]
name = plone-test
host = 127.0.0.1
blob-dir = ${buildout:directory}/var/blobstorage
user = zope
password = secret

...

[mauritsvanrees]

We just had a Plone 6 coordination meeting. I heard that the new Undo control panel may be included in the Volto version that comes with Plone 6.0 final.
With my Plone Release Manager hat on that makes me nervous, introducing a new feature while we are in beta phase. Biggest worry for me is if this needs changes in all kinds of backend packages. It looks like this is only in plone.restapi, and no changes in other packages. Is that correct? Then it should be fine. The changes in this package are quite small.
Can someone confirm that for backend it is only this package?

[MdSahil-oss]

We just had a Plone 6 coordination meeting. I heard that the new Undo control panel may be included in the Volto version that comes with Plone 6.0 final. With my Plone Release Manager hat on that makes me nervous, introducing a new feature while we are in beta phase. Biggest worry for me is if this needs changes in all kinds of backend packages. It looks like this is only in plone.restapi, and no changes in other packages. Is that correct? Then it should be fine. The changes in this package are quite small. Can someone confirm that for backend it is only this package?

@mauritsvanrees Yes! this is the only backend repository which is having changes in order to implement Undo Controlpanel and the rest of the changes is present in plone's frontend volto repository.

[sneridagh]

LGTM!
@robgietema @MdSahil-oss Is this ready to merge?

@mauritsvanrees are you ok then with having this for Plone 6?

Maybe @stevepiercy wants to take a look at the docs first.

Thanks to everybody who helped/reviewed this!

[MdSahil-oss]

@sneridagh Yes! This is ready to merge.

[stevepiercy]

I am reviewing the docs now. Please give me the opportunity to complete that.

[stevepiercy]

We reorganized the docs after this PR was started. Sorry about that. Please let me know if you need further direction with that, and let's check the rendering of the docs in Netlify, too.

[mauritsvanrees]

@mauritsvanrees are you ok then with having this for Plone 6?

Yes, fine to have this extra endpoint in Plone 6.
@MdSahil-oss Thanks for creating this!

[sneridagh]

@MdSahil-oss could you please take care of @stevepiercy comments? Then let's make it happen. Thanks!

[MdSahil-oss]

@MdSahil-oss could you please take care of @stevepiercy comments? Then let's make it happen. Thanks!

@sneridagh I will be doing it soon.

[stevepiercy]

One more that I missed on my first pass, then this can be merged!

[stevepiercy]

Thank you!

[sneridagh]

@jenkins-plone-org please run jobs