Undo ControlPanel: Fetches all the transactions from @transactions endpoint and display them in Undo-Controlpanel #3457

MdSahil-oss · 2022-07-04T11:16:04Z

Undo ControlPanel: Creates an @transactions endpoint by fetching transactions from the database plone.restapi#1455

netlify · 2022-07-04T11:16:09Z

✅ Deploy Preview for volto canceled.

Name	Link
🔨 Latest commit	`dcc4772`
🔍 Latest deploy log	https://app.netlify.com/sites/volto/deploys/6336a010f1c8e90008156f36

cypress · 2022-07-04T11:21:44Z

Test summary

372 • 0 • 15 • 0

Run details


Project	Volto
Status	Passed
Commit	`dcc4772`
Started	Sep 30, 2022 7:55 AM
Ended	Sep 30, 2022 8:09 AM
Duration	13:44 💡
OS	Linux Ubuntu - 20.04
Browser	Chrome 105

View run in Cypress Dashboard ➡️

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

tiberiuichim · 2022-07-07T10:43:03Z

Hi @MdSahil-oss. It's really good to see your contribution! I have one feedback, maybe you can take it into consideration. I've always wished that some Volto's "heavy" components (such as Contents.jsx, etc) are shorter, or at least better organized to make the JSX render part shorter, easier to understand. I've noticed that you've inlined some schema, for example, to the <Form> component. I think that can be extracted to a separate variable.

src/actions/undoControlPanel/transactions.js

src/components/index.js

src/components/manage/Controlpanels/Controlpanels.jsx

src/reducers/index.js

CHANGELOG.md

src/components/manage/Controlpanels/UndoControlpanel.jsx

MdSahil-oss · 2022-09-28T13:24:21Z

@sneridagh Do I need to resolve merge conflict from this PR ?

sneridagh · 2022-09-28T13:28:29Z

@MdSahil-oss sure, please do.

sneridagh · 2022-09-28T13:33:51Z

Regarding the changes in yarn.lock (strange ones), are you using latest (classic) yarn?

MdSahil-oss · 2022-09-28T13:49:41Z

@sneridagh I'm using 1.22.19 yarn version

MdSahil-oss · 2022-09-28T17:51:29Z

@sneridagh After rebasing my branch with maser I'm getting an error:

/home/md/GSOC_plone/volto/razzle.config.js:234
  const { include } = options.webpackOptions.babelRule;
          ^

TypeError: Cannot destructure property 'include' of 'options.webpackOptions.babelRule' as it is undefined.
    at defaultModify (/home/md/GSOC_plone/volto/razzle.config.js:234:11)
    at modifyWebpackConfig (/home/md/GSOC_plone/volto/razzle.config.js:317:27)
    at /home/md/GSOC_plone/volto/node_modules/razzle/config/createConfigAsync.js:1023:22
    at processTicksAndRejections (node:internal/process/task_queues:96:5)
error Command failed with exit code 1.

Therefore not able to test/run project locally.

sneridagh · 2022-09-28T17:52:59Z

@MdSahil-oss Delete your node_modules folder. Run yarn again.

* master: Add missing --noninteractive in the build script in package.json lazyloading of rrule lib (#3402) Display description in control panel if the field is available (#3696) Run yarn deduplicate (#3694)

sneridagh · 2022-09-30T07:52:44Z

I don't have the slightness clue of why the yarn.lock was changed. I reverted back to the master version.

@Transactions

* master: Back to development Release 16.0.0-alpha.40 Prepare for release Working copy actions now render errors if they fail (#3388) Undo ControlPanel: Fetches all the transactions from @Transactions endpoint and display them in Undo-Controlpanel (#3457) Update to use Plone 6 beta 2 (#3700) Updated deprecated moment.js code (#3160) Add missing --noninteractive in the build script in package.json

@Transactions

* master: Back to development Release 16.0.0-alpha.40 Prepare for release Working copy actions now render errors if they fail (#3388) Undo ControlPanel: Fetches all the transactions from @Transactions endpoint and display them in Undo-Controlpanel (#3457) Update to use Plone 6 beta 2 (#3700)

@Transactions

* master: (386 commits) Remove no longer present option in cypress github action, by default, headless is true (#3711) More disable flaky test regarding many users/groups (related to #3705) (#3714) [WIP] Lazyload sentry (#3012) Comment out flaky test for now regarding many users/groups (#3705) Back to development Release 16.0.0-alpha.40 Prepare for release Working copy actions now render errors if they fail (#3388) Undo ControlPanel: Fetches all the transactions from @Transactions endpoint and display them in Undo-Controlpanel (#3457) Update to use Plone 6 beta 2 (#3700) Updated deprecated moment.js code (#3160) Add missing --noninteractive in the build script in package.json lazyloading of rrule lib (#3402) Display description in control panel if the field is available (#3696) Run yarn deduplicate (#3694) Back to development Release 16.0.0-alpha.39 Prepare for release Fix call to `@plone/scripts/i18n` (now a commonJS module) (#3693) Back to development (@plone/scripts) ...

@Transactions

* master: (59 commits) Back to development (generator-volto) Release generate-volto 5.9.1 Prepare for release Add missing --noninteractive in the generator template Add user form password reset request (#3710) Usability fixes in addon control panel (#3707) Fix convenience api folder versions spanish translation (#3709) basque translation (#3708) Remove no longer present option in cypress github action, by default, headless is true (#3711) More disable flaky test regarding many users/groups (related to #3705) (#3714) [WIP] Lazyload sentry (#3012) Comment out flaky test for now regarding many users/groups (#3705) Back to development Release 16.0.0-alpha.40 Prepare for release Working copy actions now render errors if they fail (#3388) Undo ControlPanel: Fetches all the transactions from @Transactions endpoint and display them in Undo-Controlpanel (#3457) Update to use Plone 6 beta 2 (#3700) Updated deprecated moment.js code (#3160) ...

@Transactions

* master: (59 commits) Back to development (generator-volto) Release generate-volto 5.9.1 Prepare for release Add missing --noninteractive in the generator template Add user form password reset request (#3710) Usability fixes in addon control panel (#3707) Fix convenience api folder versions spanish translation (#3709) basque translation (#3708) Remove no longer present option in cypress github action, by default, headless is true (#3711) More disable flaky test regarding many users/groups (related to #3705) (#3714) [WIP] Lazyload sentry (#3012) Comment out flaky test for now regarding many users/groups (#3705) Back to development Release 16.0.0-alpha.40 Prepare for release Working copy actions now render errors if they fail (#3388) Undo ControlPanel: Fetches all the transactions from @Transactions endpoint and display them in Undo-Controlpanel (#3457) Update to use Plone 6 beta 2 (#3700) Updated deprecated moment.js code (#3160) ...

MdSahil-oss added 9 commits May 31, 2022 21:27

Added Icon of undo-control-panel in control-panel

f82f40f

undoControlPanel updated1

192b0a3

Added action and Reducer for undoControlPanel

c5fd3ae

Finished Transactions fetching

2452fa7

Button to undo has been added

4af2988

Enhanced

cc98756

added undo control panel

72c17f4

Merge remote-tracking branch 'upstream/master' into undo-control-panel

c0c3e26

Fixed Package.json

5b2d031

MdSahil-oss requested review from robgietema and tisto July 4, 2022 11:16

Enhanced

42b9eb0

MdSahil-oss added 3 commits July 9, 2022 19:57

Enhanced

9647588

Enhanced

dea4f05

Merge remote-tracking branch 'upstream/master' into undo-control-panel

eb27db6

robgietema requested changes Jul 15, 2022

View reviewed changes

MdSahil-oss added 7 commits July 18, 2022 18:59

Enhanced

40490d9

Merge remote-tracking branch 'upstream/master' into undo-control-panel

1dcf588

Enhanced

a2f3e39

Merge remote-tracking branch 'upstream/master' into undo-control-panel

41009e7

Enhanced

42698d0

Updated as per @robgietema suggestions

8b82153

Added test cases

157b094

MdSahil-oss requested a review from robgietema July 26, 2022 09:41

MdSahil-oss and others added 3 commits July 26, 2022 16:26

Merge conflict has been resolved

c1faf49

Deleted package-lock.json

afff7c3

Updated changelog

7f27165

robgietema reviewed Aug 30, 2022

View reviewed changes

CHANGELOG.md Outdated Show resolved Hide resolved

robgietema reviewed Aug 30, 2022

View reviewed changes

src/components/manage/Controlpanels/UndoControlpanel.jsx Outdated Show resolved Hide resolved

MdSahil-oss added 2 commits August 30, 2022 16:51

Updated changes as per @robgietema suggestion

ab9b5af

merge conflict has been resolved

bfcc56b

robgietema removed the request for review from tisto September 6, 2022 07:48

robgietema approved these changes Sep 6, 2022

View reviewed changes

MdSahil-oss and others added 4 commits September 7, 2022 14:56

Merge remote-tracking branch 'upstream/master' into undo-control-panel

48530db

Changed user_name to username

66b2219

Merge remote-tracking branch 'upstream/master' into undo-control-panel

0291b51

Merge branch 'master' into undo-control-panel

a4e3546

sneridagh added this to the 16.x.x milestone Sep 27, 2022

MdSahil-oss and others added 5 commits September 28, 2022 23:58

Resolved all merge conflict

d60b17e

Removed merge conflict

fb27114

Merge branch 'master' into undo-control-panel

2627c33

Merge branch 'master' into undo-control-panel

6691ad4

* master: Add missing --noninteractive in the build script in package.json lazyloading of rrule lib (#3402) Display description in control panel if the field is available (#3696) Run yarn deduplicate (#3694)

Revert to master yarn.lock

dcc4772

sneridagh merged commit 2d72925 into master Oct 1, 2022

sneridagh deleted the undo-control-panel branch October 1, 2022 16:37

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Undo ControlPanel: Fetches all the transactions from @transactions endpoint and display them in Undo-Controlpanel #3457

Undo ControlPanel: Fetches all the transactions from @transactions endpoint and display them in Undo-Controlpanel #3457

MdSahil-oss commented Jul 4, 2022 •

edited by sneridagh

Loading

netlify bot commented Jul 4, 2022 •

edited

Loading

cypress bot commented Jul 4, 2022 •

edited

Loading

tiberiuichim commented Jul 7, 2022

MdSahil-oss commented Sep 28, 2022

sneridagh commented Sep 28, 2022

sneridagh commented Sep 28, 2022 •

edited

Loading

MdSahil-oss commented Sep 28, 2022

MdSahil-oss commented Sep 28, 2022

sneridagh commented Sep 28, 2022

sneridagh commented Sep 30, 2022

Undo ControlPanel: Fetches all the transactions from @transactions endpoint and display them in Undo-Controlpanel #3457

Undo ControlPanel: Fetches all the transactions from @transactions endpoint and display them in Undo-Controlpanel #3457

Conversation

MdSahil-oss commented Jul 4, 2022 • edited by sneridagh Loading

netlify bot commented Jul 4, 2022 • edited Loading

✅ Deploy Preview for volto canceled.

cypress bot commented Jul 4, 2022 • edited Loading

Test summary

Run details

tiberiuichim commented Jul 7, 2022

MdSahil-oss commented Sep 28, 2022

sneridagh commented Sep 28, 2022

sneridagh commented Sep 28, 2022 • edited Loading

MdSahil-oss commented Sep 28, 2022

MdSahil-oss commented Sep 28, 2022

sneridagh commented Sep 28, 2022

sneridagh commented Sep 30, 2022

MdSahil-oss commented Jul 4, 2022 •

edited by sneridagh

Loading

netlify bot commented Jul 4, 2022 •

edited

Loading

cypress bot commented Jul 4, 2022 •

edited

Loading

sneridagh commented Sep 28, 2022 •

edited

Loading