Skip next/previous info for old versions if it can't be obtained #1651
Conversation
|
@davisagli thanks for creating this Pull Request and helping to improve Plone! TL;DR: Finish pushing changes, pass all other checks, then paste a comment: To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically. Happy hacking! |
✅ Deploy Preview for plone-restapi canceled.
|
|
@jenkins-plone-org please run jobs |
|
@tisto could you please take a look, merge and release? Thx! |
There was a problem hiding this comment.
Keep in mind that the shape of the response now has changed and the consuming code might need changes to reflect that.
Instead of having {previous_item: ..., next_item: ...}, these keys now will be missing from the response. imho this is more correct than {previous_item: null, next_item: null} as the object doesn't or can't provide the plone.app.dexterity.behaviors.nextprevious behaviour at all.
lgtm
|
@tisto I updated it to return |
* Skip next/previous info for old versions if it can't be obtained * changelog * make it fully backwards compatible
…) (#1681) * Skip next/previous info for old versions if it can't be obtained * changelog * make it fully backwards compatible
Fixes #1650
If the item was renamed or moved, then its id might not be found in the current object's container. In that case let's degrade gracefully and leave out the previous_item and next_item rather than raising a ValueError.