Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

7.x.x - Fix nextprev with versions exportimport when object moved #1679

Closed
wants to merge 2 commits into from

Conversation

avoinea
Copy link
Member

@avoinea avoinea commented Aug 14, 2023

No description provided.

@mister-roboto
Copy link

@avoinea thanks for creating this Pull Request and helping to improve Plone!

TL;DR: Finish pushing changes, pass all other checks, then paste a comment:

@jenkins-plone-org please run jobs

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically.

Happy hacking!

@avoinea avoinea changed the title Fix nextprev with versions exportimport when object moved 7.x.x - Fix nextprev with versions exportimport when object moved Aug 14, 2023
Copy link
Member

@davisagli davisagli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@avoinea I'd have a slight preference for backporting #1651, which includes a test -- but this looks equivalent.

@avoinea
Copy link
Member Author

avoinea commented Aug 16, 2023

@davisagli Yes, please go for it!

@davisagli
Copy link
Member

I merged #1681 instead

@davisagli davisagli closed this Sep 4, 2023
@davisagli davisagli deleted the 7.x.x-fix-exportimport-versions branch September 4, 2023 05:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants