Dockerfile for plone.restapi #301
Conversation
site.cfg
Outdated
| eggs += plone.restapi | ||
|
|
||
| [versions] | ||
| plone.stringinterp = 1.0.14 |
There was a problem hiding this comment.
I don't think you need this pin, thus you can remove:
[versions]
plone.stringinterp = 1.0.14
Dockerfile
Outdated
|
|
||
| USER root | ||
| RUN apt-get update \ | ||
| && apt-get install -y --no-install-recommends build-essential \ |
There was a problem hiding this comment.
You may not need to install build-essential if you don't compile C modules. Thus you can remove:
USER root
RUN apt-get update \
&& apt-get install -y --no-install-recommends build-essential \
&& rm -rf /var/lib/apt/lists/*
USER plone
There was a problem hiding this comment.
If you use apt install, you also may want to use apt-get clean
.travis.yml
Outdated
| @@ -24,3 +24,4 @@ after_success: | |||
| - bin/createcoverage | |||
| - pip install coverage==3.7.1 coveralls | |||
| - coveralls | |||
| - docker.io build --tag plone-dev:207.03.29 . | |||
|
@tisto a changelog entry please 😄 |
|
@tisto yes ;) |
|
@gforcada a changelog entry does not make much sense here in my opinion. This is not a change on the package itself. |
|
@avoinea do you know who can help me with the plone credentials for dockerhub? We need to add them to the plone.restapi repo, to be able to use it to make travis automatically upload docker images to dockerhub. |
.travis.yml
Outdated
| @@ -24,3 +24,5 @@ after_success: | |||
| - bin/createcoverage | |||
| - pip install coverage==3.7.1 coveralls | |||
| - coveralls | |||
| - docker.io build --tag plone.restapi:$(git rev-parse HEAD) . | |||
| # - docker.io push kitconcept/plone.restapi | |||
There was a problem hiding this comment.
Reminder: Do not forget to change that to plone, later on, otherwise you will push it to kitconcept on dockr hub and not to plone :)
There was a problem hiding this comment.
Absolutely. I need the plone credentials on the plone.restapi first though. :)
There was a problem hiding this comment.
Oh and make sure to check: https://docs.travis-ci.com/user/docker/
You need:
services:
- docker
and change
docker.io
to docker
There was a problem hiding this comment.
@svx I don't want to run docker on travis. Just automatically build the latest version and push it to dockerhub. Other projects should use the plone.restapi docker service on travis then in order to run tests against it (with their custom front-ends for instance).
There was a problem hiding this comment.
I am a bit confused. On Ubuntu I need to user docker.io. Maybe travis is using a symlink to be able to use docker instead when you use a docker service. Anyways, will test this as soon as I have the plone dockerhub credentials. :)
There was a problem hiding this comment.
Ok, but if you want travis to push you need docker installed, right ?
Yeah, this is when you install docker from the ubuntu repositories, but if you for example install docker from the docker repos it is called docker.
I do not know how travis uses/installs docker there are different ways.
There was a problem hiding this comment.
@svx you are correct. It just turned out my commands weren't executed at all. :(
No description provided.