Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dockerfile for plone.restapi #301

Merged
merged 8 commits into from May 1, 2017
Merged

Dockerfile for plone.restapi #301

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
08f1e96
Add Dockerfile and site.cfg; Build docker image on travis.
tisto Mar 29, 2017
77b0c39
Docker: fix date and use latest as a tag.
tisto Mar 29, 2017
9a265d2
Docker: use latest git hash as a tag on docker hub.
tisto Mar 29, 2017
e9d7acb
Docker: remove unnecessary version pin.
tisto Mar 29, 2017
e9680f8
Docker: No need to install build-essential.
tisto Mar 29, 2017
1dab15d
Merge branch 'master' into docker
tisto May 1, 2017
63d876d
Add changelog entry to make gforcada happy. ;)
tisto May 1, 2017
68357f6
Push docker image to plone instead of kitconcept.
tisto May 1, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 1 addition & 0 deletions .travis.yml
View file
Open in desktop
Expand Up @@ -24,3 +24,4 @@ after_success:
- bin/createcoverage
- pip install coverage==3.7.1 coveralls
- coveralls
- docker.io build --tag plone-dev:207.03.29 .
Copy link
Sponsor Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo in 207.03.29 ;)

11 changes: 11 additions & 0 deletions Dockerfile
View file
Open in desktop
@@ -0,0 +1,11 @@
FROM plone:4
MAINTAINER "Timo Stollenwerk" <tisto@plone.org>

USER root
RUN apt-get update \
&& apt-get install -y --no-install-recommends build-essential \
Copy link
Sponsor Member

@avoinea avoinea Mar 29, 2017 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You may not need to install build-essential if you don't compile C modules. Thus you can remove:

USER root
RUN apt-get update \
 && apt-get install -y --no-install-recommends  build-essential \
 && rm -rf /var/lib/apt/lists/*
USER plone

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you use apt install, you also may want to use apt-get clean

&& rm -rf /var/lib/apt/lists/*
USER plone

COPY site.cfg /plone/instance/
RUN bin/buildout -c site.cfg
7 changes: 7 additions & 0 deletions site.cfg
View file
Open in desktop
@@ -0,0 +1,7 @@
[buildout]
extends = buildout.cfg
eggs += plone.restapi

[versions]
plone.stringinterp = 1.0.14
Copy link
Sponsor Member

@avoinea avoinea Mar 29, 2017 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think you need this pin, thus you can remove:

[versions]
plone.stringinterp = 1.0.14