Rename Dexterity content before adding it to a container #577
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is more consistent with the behavior when creating content TTW. Also it avoids creating a savepoint. AT content still has to be renamed after beeing added to a container.
1 similar comment
|
Thx! |
phgross
added a commit
to 4teamwork/opengever.core
that referenced
this pull request
Aug 8, 2018
The `rename` helper method has been droped by plone/plone.restapi#577 thus we use now the `add` method and sets the `rename` flag to True.
phgross
added a commit
to 4teamwork/opengever.core
that referenced
this pull request
Aug 8, 2018
With plone/plone.restapi#577 an `create` keyword has been introduced. Because initalizing the title and metadata from the message file, makes only sense after creation, therefore we make the initalization conditionally on the `create` flag.
phgross
added a commit
to 4teamwork/opengever.core
that referenced
this pull request
Aug 8, 2018
The `rename` helper method has been droped by plone/plone.restapi#577 thus we use now the `add` method and sets the `rename` flag to True.
phgross
added a commit
to 4teamwork/opengever.core
that referenced
this pull request
Aug 8, 2018
With plone/plone.restapi#577 an `create` keyword has been introduced. Because initalizing the title and metadata from the message file, makes only sense after creation, therefore we make the initalization conditionally on the `create` flag.
phgross
added a commit
to 4teamwork/opengever.core
that referenced
this pull request
Aug 9, 2018
The `rename` helper method has been droped by plone/plone.restapi#577 thus we use now the `add` method and sets the `rename` flag to True.
phgross
added a commit
to 4teamwork/opengever.core
that referenced
this pull request
Aug 9, 2018
With plone/plone.restapi#577 an `create` keyword has been introduced. Because initalizing the title and metadata from the message file, makes only sense after creation, therefore we make the initalization conditionally on the `create` flag.
phgross
added a commit
to 4teamwork/opengever.core
that referenced
this pull request
Aug 9, 2018
The `rename` helper method has been droped by plone/plone.restapi#577 thus we use now the `add` method and sets the `rename` flag to True.
phgross
added a commit
to 4teamwork/opengever.core
that referenced
this pull request
Aug 9, 2018
With plone/plone.restapi#577 an `create` keyword has been introduced. Because initalizing the title and metadata from the message file, makes only sense after creation, therefore we make the initalization conditionally on the `create` flag.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is more consistent with the behavior when creating content TTW.
Also it avoids creating a savepoint.
AT content still has to be renamed after beeing added to a container.
Fixes #570