Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

implement "sort" feature to rearrange all folder items #813

Merged
merged 4 commits into from Sep 24, 2020
Merged

implement "sort" feature to rearrange all folder items #813

merged 4 commits into from Sep 24, 2020

Conversation

petschki
Copy link
Member

@petschki petschki commented Oct 24, 2019 •
edited

fixes #812
related plone/volto#940

@mister-roboto
Copy link

@petschki thanks for creating this Pull Request and help improve Plone!

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass.

Whenever you feel that the pull request is ready to be tested, either start all jenkins jobs pull requests by yourself, or simply add a comment in this pull request stating:

@jenkins-plone-org please run jobs

With this simple comment all the jobs will be started automatically.

Happy hacking!

@petschki
Copy link
Member Author

@jenkins-plone-org please run jobs

@petschki
Copy link
Member Author

@jenkins-plone-org please run jobs

@petschki
Copy link
Member Author

@jenkins-plone-org please run jobs

@petschki petschki requested a review from tisto October 25, 2019 06:23
@petschki petschki mentioned this pull request Oct 25, 2019
Closed
@lukasgraf
Copy link
Member

As per my comment in plone/volto#940: Is the intent of those user interface actions really to persistently change the sort order of items in the DB, not just affect query sorting? It seems strange to me, but to be honest it's been quite a while since I just a plain out-of-the-box folder contents view, so just wanting to make sure 😉

Please also note that there is currently a discussion in the @plone/restapi-team on whether we want to move ordering functionality to a dedicated @order endpoint, instead doing it via the pseudo-field ordering. If we were to to that, this one should obviously be in the same style (so a @sort endpoint). We should therefore conclude that discussion before merging this one.

@petschki
Copy link
Member Author

Thanks for the pointer to the discussion. apart from the UI point of view in volto I think we should provide a rearrange action here.

@tisto tisto merged commit 4feec80 into master Sep 24, 2020
@tisto tisto deleted the issue-812-resort-all-items branch September 24, 2020 21:00
@tisto
Copy link
Sponsor Member

tisto commented Sep 24, 2020

@petschki sorry it took so long to review and merge your PR. Will do a release in the next days...

tisto pushed a commit that referenced this pull request Sep 29, 2020
@petschki @tisto
implement "sort" feature to rearrange all folder items (#813)
a0dab97 
* implement `sort` feature

* update documentation [ci skip]

* rename doc http example

* fix docs
tisto pushed a commit that referenced this pull request Oct 8, 2020
@petschki @tisto
implement "sort" feature to rearrange all folder items (#813)
d5f0058 
* implement `sort` feature

* update documentation [ci skip]

* rename doc http example

* fix docs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tisto tisto tisto approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement "sort" endpoint for reordering folder contents
4 participants
@petschki @mister-roboto @lukasgraf @tisto