Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

folder contents - sorting options do not work #940

Closed
petschki opened this issue Oct 24, 2019 · 7 comments
Closed

folder contents - sorting options do not work #940

petschki opened this issue Oct 24, 2019 · 7 comments
Projects
Milestone

Comments

@petschki
Copy link
Member

petschki commented Oct 24, 2019

choosing any of the sorting options do not work.

Bildschirmfoto 2019-10-24 um 19 01 21

@petschki
Copy link
Member Author

erm ... looks like the sort feature is missing in plone.restapi ... at least I didn't find it ...

@tisto
Copy link
Sponsor Member

tisto commented Oct 25, 2019

@petschki there is an option to sort objects in a folder:

https://plonerestapi.readthedocs.io/en/latest/content.html#reordering-sub-resources

We had issues with that in the past as well. Will try to find time to write an acceptance test to prove that it is not working.

@petschki
Copy link
Member Author

@tisto yes I saw the reodering part, but that is only for sorting one object within a folder. I've implemented the rearrange functionality here: plone/plone.restapi#813 this also works with the current volto sort PATCH call ...

@lukasgraf
Copy link
Member

Hang on - shouldn't this much rather be a sorted query instead of persistent reordering of folder items as is proposed in the plone.restapi pull request?

I don't currently have a whole lot of context of this user interface, but it looking like a folderContents style listing and the menu saying Elemente sortieren nach... I would expect that option to affect displayed sorting, not necessarily to cause a permanent change in the DB.

@petschki
Copy link
Member Author

petschki commented Oct 29, 2019

@lukasgraf that’s what I also thought in the beginning but volto does a sort PATCH call and then a normal GET call with objPositionInParent as sort Index so I interpreted this as the rearrange functionality from the classic folder_contents view.

This should be discussed from an UX point of view here whether this functionality should be done persistent here or a separate rearrange action should be placed somewhere else.

/cc @sneridagh

@lukasgraf
Copy link
Member

Gotcha. It's more a UX question then. In English it's spelled "Rearrange", whereas the German "Sortieren nach..." doesn't scream "this will change items in the DB". So maybe something like "Umsortieren", "Neu sortieren nach" or "Neu anordnen" might work better in German.

@tisto tisto added this to To do in Volto 4 Final via automation Feb 9, 2020
@tisto tisto added this to the 4.0.0 milestone Feb 9, 2020
@sneridagh sneridagh added this to To do in Volto 5 via automation Mar 21, 2020
@sneridagh sneridagh removed this from To do in Volto 4 Final Mar 21, 2020
@ksuess
Copy link
Member

ksuess commented May 8, 2020

Fixed by #1324

@ksuess ksuess closed this as completed May 20, 2020
Volto 5 automation moved this from To do to Done May 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Volto 5
  
Done
Development

No branches or pull requests

4 participants