Respect types_not_searched field for search
#862
Conversation
|
@rodfersou thanks for creating this Pull Request and help improve Plone! To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass. Whenever you feel that the pull request is ready to be tested, either start all jenkins jobs pull requests by yourself, or simply add a comment in this pull request stating: With this simple comment all the jobs will be started automatically. Happy hacking! |
rodfersou
changed the title
types_not_searched field for search
src/plone/restapi/search/handler.py
Outdated
| types = query.get('portal_type', []) | ||
| if 'query' in types: | ||
| types = types['query'] | ||
| query['portal_type'] = self.filter_types(types) |
There was a problem hiding this comment.
src/plone/restapi/search/handler.py
Outdated
| plone_utils = getToolByName(self.context, 'plone_utils') | ||
| if not isinstance(types, list): | ||
| types = [types] | ||
| return plone_utils.getUserFriendlyTypes(types) |
There was a problem hiding this comment.
| def test_types_not_searched(self): | ||
| registry = getUtility(IRegistry) | ||
| search_settings = registry.forInterface(ISearchSchema, prefix="plone") | ||
| search_settings.types_not_searched = ('Folder',) |
There was a problem hiding this comment.
For some reason, this configuration is changing when running the search.
Need help to figure out it.
There was a problem hiding this comment.
the test is failing, and when debugging it, realized that the types_not_searched configuration is missing before add the filter in the search ( Folder type is being listed)
| def test_types_not_searched(self): | ||
| registry = getUtility(IRegistry) | ||
| search_settings = registry.forInterface(ISearchSchema, prefix="plone") | ||
| search_settings.types_not_searched = ('Folder',) |
|
@sneridagh added your suggestion to filter just if |
|
@jenkins-plone-org please run jobs |
|
@jenkins-plone-org please run jobs |
|
@jenkins-plone-org please run jobs |
|
@sneridagh I don't get why it is failing since the field is there... https://github.com/plone/plone.app.controlpanel/blob/2.3.11/plone/app/controlpanel/search.py#L59-L65 Error in test test_types_not_searched (plone.restapi.tests.test_search.TestSearchFunctional)
Traceback (most recent call last):
File "/Users/rodrigo/.asdf/installs/python/2.7.17/lib/python2.7/unittest/case.py", line 329, in run
testMethod()
File "/Users/rodrigo/.projects/plone/plone.restapi/src/plone/restapi/tests/test_search.py", line 139, in test_types_not_searched
search_settings = registry.forInterface(ISearchSchema, prefix="plone")
File "/Users/rodrigo/.projects/cache/eggs/plone.registry-1.0.5-py2.7.egg/plone/registry/registry.py", line 78, in forInterface
name
KeyError: 'Interface `plone.app.controlpanel.search.ISearchSchema` defines a field `sort_on`, for which there is no record.' |
|
See #904 |
* add commit to make registry setting permanent * add commit to make registry setting permanent * enable plone.restapi in development * handle plone <5 settings
|
@jenkins-plone-org please run jobs |
|
Sorry, but disn’t we decided to not go for this one? @tisto ? TL;DR of this is: the @search endpoint is not the Plone search view... |
|
uh..that's not nice ;) |
I just looked at the technical POV. |
|
Sorry folks, this PR was supposed to be closed when we stopped working on it. This is a complex topic that touches REST API design decisions and requires careful consideration. Closing the PR now. |
closes #861