Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix not searched test #904

Merged
merged 4 commits into from
Apr 9, 2020
Merged

Fix not searched test #904

merged 4 commits into from
Apr 9, 2020

Conversation

cekk
Copy link
Member

@cekk cekk commented Apr 8, 2020

No description provided.

@cekk cekk changed the title Fix not searched test [wip] Fix not searched test Apr 8, 2020
@coveralls
Copy link

coveralls commented Apr 8, 2020 •
edited
Loading

Coverage Status

Coverage remained the same at 95.67% when pulling 3f9c047 on fix_not_searched_test into 1f32b47 on respect-types-not-searched.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 95.185% when pulling 69fe6d1 on fix_not_searched_test into 1f32b47 on respect-types-not-searched.

@cekk cekk requested a review from rodfersou April 8, 2020 13:32
@cekk
Copy link
Member Author

cekk commented Apr 8, 2020

@rodfersou this fix your errors on tests.

The problem was that on 4.3 search settings are not on the registry but in site_properties ;)

@cekk cekk changed the title [wip] Fix not searched test Fix not searched test Apr 8, 2020
@cekk cekk mentioned this pull request Apr 8, 2020
Closed
@rodfersou
Copy link
Member

@cekk thanks

rodfersou
rodfersou approved these changes Apr 9, 2020
View reviewed changes
Copy link
Member

@rodfersou rodfersou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rodfersou rodfersou merged commit 774a4b0 into respect-types-not-searched Apr 9, 2020
@rodfersou rodfersou deleted the fix_not_searched_test branch April 9, 2020 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rodfersou rodfersou rodfersou approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cekk @coveralls @rodfersou