Merge pull request #56 from plone/async-install-functions

handle async addon functions

src/plone.server/CHANGELOG.rst

@@ -3,6 +3,9 @@
 
 New features:
 
+- install, uninstall methods for addon class can now be async
+  [vangheem]
+
 - Be able to define adapters, subscribers, permissions, roles, grant
   with decorators, not zcml
   [vangheem]

src/plone.server/plone/server/api/addons.py

@@ -6,6 +6,8 @@
 from plone.server.registry import IAddons
 from zope.i18nmessageid import MessageFactory
 
+import asyncio
+
 
 _ = MessageFactory('plone')
 
@@ -28,7 +30,10 @@ async def install(context, request):
             'Duplicate',
             _("Addon already installed"))
     handler = app_settings['available_addons'][id_to_install]['handler']
-    handler.install(request)
+    if asyncio.iscoroutinefunction(handler.install):
+        await handler.install(request)
+    else:
+        handler.install(request)
     config.enabled |= {id_to_install}
     return await get_addons(context, request)()
 
@@ -52,7 +57,10 @@ async def uninstall(context, request):
             _("Addon not installed"))
 
     handler = app_settings['available_addons'][id_to_install]['handler']
-    handler.uninstall(request)
+    if asyncio.iscoroutinefunction(handler.install):
+        await handler.uninstall(request)
+    else:
+        handler.uninstall(request)
     config.enabled -= {id_to_install}
 
 

src/plone.server/plone/server/traversal.py

@@ -150,13 +150,21 @@ async def traverse(request, parent, path):
     return await traverse(request, context, path[1:])
 
 
+def _url(request):
+    try:
+        return request.url.human_repr()
+    except AttributeError:
+        # older version of aiohttp
+        return request.path
+
+
 def generate_unauthorized_response(e, request):
     # We may need to check the roles of the users to show the real error
     eid = uuid.uuid4().hex
     message = _('Not authorized to render operation') + ' ' + eid
     user = get_authenticated_user_id(request)
     extra = {
-        'r': request.url.human_repr(),
+        'r': _url(request),
         'u': user
     }
     logger.error(
@@ -172,7 +180,7 @@ def generate_error_response(e, request, error, status=400):
     message = _('Error on execution of view') + ' ' + eid
     user = get_authenticated_user_id(request)
     extra = {
-        'r': request.url.human_repr(),
+        'r': _url(request),
         'u': user
     }
     logger.error(