-
-
Notifications
You must be signed in to change notification settings - Fork 6
-
-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
plone.session install breaks on ES6 #23
Closed
Labels
Comments
The error remains after deactivating |
mauritsvanrees
added a commit
to plone/Products.CMFPlone
that referenced
this issue
Mar 29, 2022
…one.session` resources. Fixes [`plone.session` issue 23](plone/plone.session#23). Main problem there was that the code could not traverse to the plone.session css resource, resulting in a resource None, which caused a traceback, resulting in an unstyled site. After fixing this part, I found another problem: the `plone.session` css resource had an expression `python: member is not None`, but was still loaded for anonymous users as well. It turned out that the expression was never checked. More correctly said: it looks like the expression of the last resource was used for all resources, even when this expression was empty. To fix this, I had to pass the expression to the webresource, and move some code from `browser/resource.py` to `webresource.py`. I added tests with a couple of resource bundles with different expressions.
mister-roboto
pushed a commit
to plone/buildout.coredev
that referenced
this issue
Mar 30, 2022
Branch: refs/heads/master Date: 2022-03-30T01:22:10+02:00 Author: Maurits van Rees (mauritsvanrees) <maurits@vanrees.org> Commit: plone/Products.CMFPlone@7f4efc3 Fixed evaluating expressions on resources, and especially loading `plone.session` resources. Fixes [`plone.session` issue 23](plone/plone.session#23). Main problem there was that the code could not traverse to the plone.session css resource, resulting in a resource None, which caused a traceback, resulting in an unstyled site. After fixing this part, I found another problem: the `plone.session` css resource had an expression `python: member is not None`, but was still loaded for anonymous users as well. It turned out that the expression was never checked. More correctly said: it looks like the expression of the last resource was used for all resources, even when this expression was empty. To fix this, I had to pass the expression to the webresource, and move some code from `browser/resource.py` to `webresource.py`. I added tests with a couple of resource bundles with different expressions. Files changed: A news/23.bugfix M Products/CMFPlone/resources/browser/resource.py M Products/CMFPlone/resources/utils.py M Products/CMFPlone/resources/webresource.py M Products/CMFPlone/tests/testResourceRegistries.py Repository: Products.CMFPlone Branch: refs/heads/master Date: 2022-03-30T08:28:04+02:00 Author: Alessandro Pisa (ale-rt) <alessandro.pisa@gmail.com> Commit: plone/Products.CMFPlone@3a98bcf Merge pull request #3470 from plone/maurits-fix-plone-session-resources-and-expressions Fixed plone.session resource, and evaluating expressions on resources Files changed: A news/23.bugfix M Products/CMFPlone/resources/browser/resource.py M Products/CMFPlone/resources/utils.py M Products/CMFPlone/resources/webresource.py M Products/CMFPlone/tests/testResourceRegistries.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I tried coredev 6.0 with the ES6 PLIP. Database was copied from coredev 5.2 on Python 3, and then upgraded. In one Plone site I had all extra modules installed, like placeful workflow and
plone.session
. When viewing it I got anerror while rendering plone.resourceregistries.styles
at the top of the page, which resulted in an unstyled page.Same is true for the standard Plone 5.2 site that I upgraded to Plone 6 ES6. Worked fine at first, but then I activated
plone.session
:The text was updated successfully, but these errors were encountered: