Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the Zope exception hook when using the ZServer layer. #49

Merged
merged 1 commit into from Jun 22, 2018

Conversation

Projects
None yet
3 participants
@davisagli
Copy link
Member

davisagli commented Jun 22, 2018

Some plone.rest tests were failing because they use the ZServer layer and it was not setting up the Zope exception hook in Zope 4.

@jenkins-plone-org

This comment has been minimized.

Copy link

jenkins-plone-org commented on 084d316 Jun 22, 2018

@davisagli Jenkins CI reporting about code analysis
See the full report here: https://jenkins.plone.org/job/package-plone.testing/84/violations

src/plone/testing/z2.py:98:1: C901 'uninstallProduct' is too complex (15)
src/plone/testing/z2.py:138:19: T000 Todo note found.
src/plone/testing/z2.py:414:5: C901 'Startup.setUpPatches' is too complex (11)
src/plone/testing/z2.py:829:11: T000 Todo note found.

Follow these instructions to reproduce it locally.

@davisagli davisagli merged commit cc2f063 into master Jun 22, 2018

5 of 6 checks passed

continuous-integration/travis-ci/push The Travis CI build failed
Details
Changelog verifier Entry found
Details
Plone Contributors Agreement verifier All users have signed it
Details
Plone Jenkins CI - pull-request-5.2 Job finished with success status
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.1%) to 85.156%
Details

@davisagli davisagli deleted the fix-zserver-exception-hook branch Jun 22, 2018

@davisagli davisagli referenced this pull request Jun 23, 2018

Closed

Plone 5.2 compatibility #74

@icemac

This comment has been minimized.

Copy link
Contributor

icemac commented Jun 26, 2018

This change should be ported to #48 as it will otherwise get lost on the next release. (#48 renamed the files and split zserver and wsgi parts.)

@icemac

This comment has been minimized.

Copy link
Contributor

icemac commented Jul 4, 2018

@davisagli How does this PR relate to #45? Is #45 now obsolete?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.