Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fails with setuptools 66+ #52

Closed
mauritsvanrees opened this issue Apr 6, 2023 · 0 comments
Closed

Fails with setuptools 66+ #52

mauritsvanrees opened this issue Apr 6, 2023 · 0 comments
Assignees
@mauritsvanrees

Comments

@mauritsvanrees
Copy link
Sponsor Member

The versioncheck job in coredev has been failing since we use a newer setuptools. Sample error:

Check PyPI for updates of 390 packages.
   0 OOOOOOOOOOOOOOOOOOOO
  20 OOOOOOTraceback (most recent call last):
  File "./bin/versioncheck", line 23, in <module>
    sys.exit(plone.versioncheck.script.run())
  File "/home/runner/work/buildout.coredev/buildout.coredev/eggs/plone.versioncheck-1.7.0-py3.8.egg/plone/versioncheck/script.py", line 126, in run
    check_all(pkgsinfo, args.debug_limit, nocache=args.no_cache)
  File "/home/runner/work/buildout.coredev/buildout.coredev/eggs/plone.versioncheck-1.7.0-py3.8.egg/plone/versioncheck/pypi.py", line 171, in check_all
    state, result = check(pkgname, pkgs[pkgname][current]["v"], session)
  File "/home/runner/work/buildout.coredev/buildout.coredev/eggs/plone.versioncheck-1.7.0-py3.8.egg/plone/versioncheck/pypi.py", line 77, in check
    rel_v = parse_version(release)
  File "/opt/hostedtoolcache/Python/3.8.16/x64/lib/python3.8/site-packages/pkg_resources/_vendor/packaging/version.py", line 197, in __init__
    raise InvalidVersion(f"Invalid version: '{version}'")
pkg_resources.extern.packaging.version.InvalidVersion: Invalid version: '1.4dev-r93307'
Error: Process completed with exit code 1.

We should ignore versions that cannot be parsed.
We need a change similar to this one in zest.releaser.
@mauritsvanrees mauritsvanrees self-assigned this Apr 14, 2023
mister-roboto pushed a commit to plone/buildout.coredev that referenced this issue Apr 15, 2023
@gforcada
[fc] Repository: plone.versioncheck
b7f8040 
Branch: refs/heads/master
Date: 2023-04-14T16:04:17+02:00
Author: Maurits van Rees (mauritsvanrees) <maurits@vanrees.org>
Commit: plone/plone.versioncheck@5774bd8

Ignore invalid versions.

Needed for `setuptools` 66 and higher when checking a package that has invalid versions on PyPI.
Fixes plone/plone.versioncheck#52.

For example it fails on parsing `collective.recipe.template` because it has a version `1.4dev-r93307`.
See https://pypi.org/simple/collective-recipe-template/

Files changed:
M CHANGES.rst
M src/plone/versioncheck/pypi.py
Repository: plone.versioncheck

Branch: refs/heads/master
Date: 2023-04-14T16:26:22+02:00
Author: Maurits van Rees (mauritsvanrees) <maurits@vanrees.org>
Commit: plone/plone.versioncheck@98b9d9e

Fix linting

Files changed:
M setup.cfg
M setup.py
M src/plone/versioncheck/analyser.py
M src/plone/versioncheck/formatter.py
M src/plone/versioncheck/utils.py
M tox.ini
Repository: plone.versioncheck

Branch: refs/heads/master
Date: 2023-04-14T16:38:27+02:00
Author: Maurits van Rees (mauritsvanrees) <maurits@vanrees.org>
Commit: plone/plone.versioncheck@887051e

Add classifiers for Python 3.8-3.11.

Files changed:
M setup.py
M tox.ini
Repository: plone.versioncheck

Branch: refs/heads/master
Date: 2023-04-15T10:34:35+02:00
Author: Gil Forcada Codinachs (gforcada) <gil.gnome@gmail.com>
Commit: plone/plone.versioncheck@79b4290

Merge pull request #53 from plone/maurits-ignore-invalid-version

Ignore invalid versions

Files changed:
M CHANGES.rst
M setup.cfg
M setup.py
M src/plone/versioncheck/analyser.py
M src/plone/versioncheck/formatter.py
M src/plone/versioncheck/pypi.py
M src/plone/versioncheck/utils.py
M tox.ini
mister-roboto pushed a commit to plone/buildout.coredev that referenced this issue Apr 15, 2023
@gforcada
[fc] Repository: plone.versioncheck
ffffd47 
Branch: refs/heads/master
Date: 2023-04-14T16:04:17+02:00
Author: Maurits van Rees (mauritsvanrees) <maurits@vanrees.org>
Commit: plone/plone.versioncheck@5774bd8

Ignore invalid versions.

Needed for `setuptools` 66 and higher when checking a package that has invalid versions on PyPI.
Fixes plone/plone.versioncheck#52.

For example it fails on parsing `collective.recipe.template` because it has a version `1.4dev-r93307`.
See https://pypi.org/simple/collective-recipe-template/

Files changed:
M CHANGES.rst
M src/plone/versioncheck/pypi.py
Repository: plone.versioncheck

Branch: refs/heads/master
Date: 2023-04-14T16:26:22+02:00
Author: Maurits van Rees (mauritsvanrees) <maurits@vanrees.org>
Commit: plone/plone.versioncheck@98b9d9e

Fix linting

Files changed:
M setup.cfg
M setup.py
M src/plone/versioncheck/analyser.py
M src/plone/versioncheck/formatter.py
M src/plone/versioncheck/utils.py
M tox.ini
Repository: plone.versioncheck

Branch: refs/heads/master
Date: 2023-04-14T16:38:27+02:00
Author: Maurits van Rees (mauritsvanrees) <maurits@vanrees.org>
Commit: plone/plone.versioncheck@887051e

Add classifiers for Python 3.8-3.11.

Files changed:
M setup.py
M tox.ini
Repository: plone.versioncheck

Branch: refs/heads/master
Date: 2023-04-15T10:34:35+02:00
Author: Gil Forcada Codinachs (gforcada) <gil.gnome@gmail.com>
Commit: plone/plone.versioncheck@79b4290

Merge pull request #53 from plone/maurits-ignore-invalid-version

Ignore invalid versions

Files changed:
M CHANGES.rst
M setup.cfg
M setup.py
M src/plone/versioncheck/analyser.py
M src/plone/versioncheck/formatter.py
M src/plone/versioncheck/pypi.py
M src/plone/versioncheck/utils.py
M tox.ini
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mauritsvanrees mauritsvanrees

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mauritsvanrees