Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not fail when tag versions cannot be parsed. #409

Merged
merged 3 commits into from Apr 6, 2023

Conversation

mauritsvanrees
Copy link
Member

This can happen in lasttaglog, lasttagdiff, and bumpversion, with setuptools 66 or higher. Fixes issue #408.

I see a few test failures locally that should be unrelated. The tests expect a master branch, but there is a main branch. This probably differs per git version or local configuration. Let's see what gh-actions says.

This can happen in `lasttaglog`, `lasttagdiff`, and `bumpversion`, with `setuptools` 66 or higher.
Fixes issue #408.
@mauritsvanrees
Copy link
Member Author

Okay, tests passed on gh-actions, so may be something local.
Still, I have added a commit to call git init -b main when setting up the example package in the tests. Now tests work fine locally again.

Well, there are a few test failures because I have this in my .pypirc:

[zest.releaser]
extra-message =
    [ci skip]

But never mind that for now.

zest/releaser/utils.py Show resolved Hide resolved
@mauritsvanrees mauritsvanrees merged commit 1438937 into master Apr 6, 2023
6 checks passed
@mauritsvanrees mauritsvanrees deleted the maurits-parse-version branch April 6, 2023 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants