-
-
Notifications
You must be signed in to change notification settings - Fork 12
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Move content list style classes (ul, ol, li) from base.css to public.…
…css. They were always problematic in themes, based on Sunburst which excluded public.css.
- Loading branch information
Showing
3 changed files
with
25 additions
and
26 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e513658
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TESTS FAILED
Mr.Roboto url : http://jenkins.plone.org/roboto/get_info?push=d615a6e9e2a04cd3b3959e45e188bc03
[FAILURE] kgs-plonetheme.sunburst-plone-5.0-python-2.7 kgs
[FAILURE] kgs-plonetheme.sunburst-plone-4.3-python-2.6 kgs
[SUCCESS] kgs-plonetheme.sunburst-plone-4.3-python-2.7 kgs
e513658
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@thet Plone 4.3.x uses the 1.4.x branch of plonetheme.sunburst and your commit is not in that branch.
Not sure why we cut that branch in the first place because as far as I know Plone 5.0 does not ship with plonetheme.sunburst at all ( @bloodbare is that correct?).
So what shall we do? Switch plonetheme.sunburst to master in Plone 4.3? cc @esteele
e513658
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tisto my change here is quite small, but could break the design of some sites, where not all standard plonetheme.sunburst styles are included.
But the most incompatible changes with 1.5 is the base-tag removal. I think, that's out of scope for Plone 4.3. Altough I'm using this master branch it in a current Plone 4.3 project - so far nothing is broken except the addon wildcard.foldercontents 1.x, which I already fixed.
Since plonetheme.sunburst should work with Plone 5, a new 1.5 release with the base-tag removal PLIP branch merged makes sense.
e513658
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, that makes sense. Will make a 1.5 release then.
e513658
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done: https://pypi.python.org/pypi/plonetheme.sunburst#id1
e513658
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!