Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use behavior shortnames and fixes within the behavior explanation/ usage #416

Merged
merged 8 commits into from
Jun 19, 2019
Merged

Use behavior shortnames and fixes within the behavior explanation/ usage #416

merged 8 commits into from
Jun 19, 2019

Conversation

jensens
Copy link
Sponsor Member

@jensens jensens commented Jun 12, 2019

  • Minor fixes, like using implementer and provider decorators
  • Use behavior shortnames as best practice.
  • Refine misleading explanation of IFormFieldProvider

stevepiercy
stevepiercy requested changes Jun 12, 2019
View reviewed changes
mastering-plone/behaviors_2.rst Outdated Show resolved Hide resolved
mastering-plone/behaviors_2.rst Outdated Show resolved Hide resolved
mastering-plone/behaviors_2.rst Outdated Show resolved Hide resolved
mastering-plone/behaviors_2.rst Outdated Show resolved Hide resolved
mastering-plone/behaviors_2.rst Outdated Show resolved Hide resolved
mastering-plone/behaviors_2.rst Outdated Show resolved Hide resolved
mastering-plone/behaviors_2.rst Outdated Show resolved Hide resolved
mastering-plone/behaviors_2.rst Outdated Show resolved Hide resolved
mastering-plone/behaviors_2.rst Outdated Show resolved Hide resolved
stevepiercy
stevepiercy requested changes Jun 12, 2019
View reviewed changes
Copy link
Contributor

@stevepiercy stevepiercy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've got another round of requested changes. All others look good to me! Thank you!

@jensens
Copy link
Sponsor Member Author

jensens commented Jun 13, 2019

I run a larger migration yesterday and took the waiting time to improve it here a bit, but it is really crazy. It seems the Plone documentation standards were never enforced for training material :-(

@jensens jensens merged commit 7b73b2a into master Jun 19, 2019
@jensens jensens deleted the behavior-shortnames branch June 19, 2019 22:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stevepiercy stevepiercy stevepiercy requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jensens @stevepiercy