Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the @navroot and @site controlpanels to render the <title> and the logo #3537

Merged
merged 113 commits into from Sep 14, 2023

Conversation

erral
Copy link
Sponsor Member

@erral erral commented Jul 31, 2022

To be tested with plone.restapi >= 8.40.0

  • Use navroot information to add navigation root title as the second part of the <title> tag like it is done in Classic Plone.
  • Use the site endpoint to render the Logo
  • Provide a widget to set the logo in the site control panel

Fixes #3531 #3530

@netlify
Copy link

netlify bot commented Jul 31, 2022

Deploy Preview for volto canceled.

Name Link
🔨 Latest commit 14657a9
🔍 Latest deploy log https://app.netlify.com/sites/volto/deploys/65022774d591e6000878b033

@erral

This comment was marked as outdated.

@erral

This comment was marked as outdated.

@erral

This comment was marked as outdated.

@cypress

This comment was marked as outdated.

@erral

This comment was marked as outdated.

erral and others added 4 commits July 19, 2023 12:13
Co-authored-by: Steve Piercy <web@stevepiercy.com>
Co-authored-by: Steve Piercy <web@stevepiercy.com>
Co-authored-by: Steve Piercy <web@stevepiercy.com>
@sneridagh
Copy link
Member

@erral Don't forget to add the new expander to the list!

https://github.com/plone/volto/pull/3537/files#diff-1523e3000d64e09cd6eb8370a4568715090b6763fd9192f61ab6044ac6d86fa9R238

I've merged the Expanders PR yesterday.

Copy link
Collaborator

@stevepiercy stevepiercy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Docs look good now. Thank you!

@sneridagh
Copy link
Member

@erral just pushed a fix, after this, it should be ready.

@erral
Copy link
Sponsor Member Author

erral commented Sep 12, 2023

@erral just pushed a fix, after this, it should be ready.

thanks! I didn't understand what was going on!

@erral
Copy link
Sponsor Member Author

erral commented Sep 13, 2023

At last this is green!!!! 😅

@sneridagh sneridagh merged commit 535c6ae into master Sep 14, 2023
43 checks passed
@sneridagh sneridagh deleted the site-and-navroot branch September 14, 2023 08:45
@sneridagh
Copy link
Member

I for got to Approve it, but I do :)

sneridagh added a commit that referenced this pull request Sep 18, 2023
* master:
  Add external className to slate Link view. (#5188)
  Release generate-volto 7.0.0-alpha.6
  Fix addon i18n local command when executed outside the scope of a Volto project. (#5181)
  Release 17.0.0-alpha.26
  Use the @navroot and @site controlpanels to render the <title> and the logo (#3537)
  User / Groups search control panel / sharing panel improvements #4551 (#5053)
  User Control Panel improvements (#4572)
  Fix generator build
  Release generate-volto 7.0.0-alpha.5
  Add dockerized approach to add-on generator (#5167)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Site (Navigation Root) title not included in the TITLE of the site
8 participants