Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User Control Panel improvements #4572

Merged
merged 42 commits into from Sep 14, 2023
Merged

User Control Panel improvements #4572

merged 42 commits into from Sep 14, 2023

Conversation

erral
Copy link
Sponsor Member

@erral erral commented Mar 18, 2023

fixes #4551 and #4018

This PR contains the following functionalities identified in #4551:

  • Show the username next to the fullname in the user controlpanel
  • Don't show the user table headings when many_users setting is true and no search have been made.
  • Show "no results found" when doing a search in the user controlpanel and there are no results.
  • Don't show the group table headings when many_groups setting is true and no search have been made.
  • Show "no results found" when doing a search in the group controlpanel and there are no results.

And the following identifed in #4018

  • Add a button to Edit the user data in a ModalForm following the userschema configured in the back-end

@netlify
Copy link

netlify bot commented Mar 18, 2023

Deploy Preview for volto canceled.

Name Link
🔨 Latest commit 0784d6b
🔍 Latest deploy log https://app.netlify.com/sites/volto/deploys/6415a9520c98e50008e40d08

@netlify
Copy link

netlify bot commented Mar 18, 2023

Deploy Preview for volto canceled.

Name Link
🔨 Latest commit f610cc6
🔍 Latest deploy log https://app.netlify.com/sites/volto/deploys/65020afe2280290008fc0687

@cypress
Copy link

cypress bot commented Mar 18, 2023

Passing run #7159 ↗︎

0 577 20 0 Flakiness 0
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.

Details:

Merge branch 'master' into erral-user-controlpanel
Project: Volto Commit: 8dd8ee40d7
Status: Passed Duration: 15:35 💡
Started: Sep 11, 2023 5:34 PM Ended: Sep 11, 2023 5:49 PM

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@erral erral requested a review from ionlizarazu March 19, 2023 14:21
@erral erral requested a review from wesleybl March 19, 2023 16:11
@erral erral marked this pull request as ready for review March 19, 2023 18:38
@wesleybl
Copy link
Member

Show "no results found" when doing a search in the user controlpanel and there are no results.
Show "no results found" when doing a search in the group controlpanel and there are no results.

I see the string "undefined" instead of "no results found"

I think this PR still doesn't close #4018. I would expect all field names and descriptions to come from the backend. But this can be done in another PR.

@erral
Copy link
Sponsor Member Author

erral commented Mar 20, 2023

Show "no results found" when doing a search in the user controlpanel and there are no results.
Show "no results found" when doing a search in the group controlpanel and there are no results.

I see the string "undefined" instead of "no results found"

Ups, I will check it.

I think this PR still doesn't close #4018. I would expect all field names and descriptions to come from the backend. But this can be done in another PR.

The username, password, roles and groups fields of the edit form are not part of the userschema, so we need something else in the REST API to handle them in the back-end.

Copy link
Member

@ksuess ksuess left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change of user data should trigger an update of the list of users.

src/components/manage/Controlpanels/Users/RenderUsers.jsx Outdated Show resolved Hide resolved
@nileshgulia1
Copy link
Member

I am eagerly anticipating the merger!

@erral
Copy link
Sponsor Member Author

erral commented Jul 28, 2023

If you need me to review something, I will be off until at least 11th of August

@sneridagh sneridagh added this to the Plone 6.1 milestone Sep 12, 2023
@sneridagh sneridagh merged commit 7d555ad into master Sep 14, 2023
41 checks passed
@sneridagh sneridagh deleted the erral-user-controlpanel branch September 14, 2023 08:11
sneridagh added a commit that referenced this pull request Sep 14, 2023
Co-authored-by: Ion Lizarazu <ilizarazu@codesyntax.com>
Co-authored-by: nileshgulia1 <nileshgulia@gmail.com>
Co-authored-by: Víctor Fernández de Alba <sneridagh@gmail.com>
sneridagh added a commit that referenced this pull request Sep 18, 2023
* master:
  Add external className to slate Link view. (#5188)
  Release generate-volto 7.0.0-alpha.6
  Fix addon i18n local command when executed outside the scope of a Volto project. (#5181)
  Release 17.0.0-alpha.26
  Use the @navroot and @site controlpanels to render the <title> and the logo (#3537)
  User / Groups search control panel / sharing panel improvements #4551 (#5053)
  User Control Panel improvements (#4572)
  Fix generator build
  Release generate-volto 7.0.0-alpha.5
  Add dockerized approach to add-on generator (#5167)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

User control panel improvements
7 participants