Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

can't edit on mobile as hard to close and reopen settings #3910

Open
djay opened this issue Nov 17, 2022 · 0 comments · May be fixed by #3912
Open

can't edit on mobile as hard to close and reopen settings #3910

djay opened this issue Nov 17, 2022 · 0 comments · May be fixed by #3912

Comments

@djay
Copy link
Member

djay commented Nov 17, 2022

Problems.

Currently editing on mobile is not really possible partly due to how settings sidebar works

While editing on mobile might not be a goal for 6.0 release it seems a shame to let something small like this to get in the way doing basic edits.

Blocks settings

  • block settings open by default on mobile taking up most of the screen
  • Blocks setting hide is not obvious. very hard to discover (mobile and desktop)
  • settings reopen is also hard to find (mobile and desktop)
  • settings reopen is close to the edge of the screen so hard to click on some mobiles

Describe the solution you'd like

toggle settings button

Implement the quanta solution of toggle in the toolbar now.
Note: this is from quanta design. Quanta toolbar is not needed for this, and we'd still keep the tabs in the settings

image

image

  • cog in bottom of toobar which toggles the open and close state of the settings sidebar
    • con: bit weird to have toggle on left to open something on the right but should be fine
    • should be at the bottom of toolbar since settings is not changing the page state.
  • also close button top left in settings
  • don't change how choice of block vs page settings shown for now
  • keep the current "hardly visible" open close toggle for now
  • make an experimental feature - RFC: Experimental feature flags #3896
    • turned on my default?

What to do about undo, cut and paste?

  • for the moment put them above the settings button since least amount of change
    con: they don't below together and undo buttons should probably move

Alternatives considered

  • if there is a quanta block menu then there could also be a "settings" item there that specifically opens block settings

    • why:
      • fixes: not obvious how to close settings
      • fixes: not obvious how reopen settings
      • fixes: hard to reopen settings on mobile
  • settings in toolbar always opens page settings

Placement of button and undo

  • put settings next to save and cancel

    • con: its confusing. it's not a page level action
  • propose putting undo into a context menu in the toolbar

    • it doesn't make sense to put settings with undo since they are different kind of actions
    • context menu would be above save so it's in the right place on horizontal mobile view
    • pro: can put other functions later like find and replace
  • propose removing cut and paste from toolbar and using the material design select pattern instead

  • gestures only for undo/redo

    • undo should not be visible says apple. we should use a gesture,
    • android doesn't have a standard gesture for undo
  • perhaps have snackbar to allow for UI to undo

  • have an edit mode

    • if an edit is made then replace save cancel bar with undo bar with settings undo redo accept
    • tick/accept returns you to save and cancel bar
    • this is what google docs mobile does (but then they don't have a "save")

Additional context

full quanta design which combines block menu and slate into one. It switched between block settings and page settings based on if a block was selected or not?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant