Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in english translation and add missing french translation #4085

Merged
merged 7 commits into from
Dec 12, 2022

Conversation

mpeeters
Copy link
Member

No description provided.

@netlify
Copy link

netlify bot commented Dec 11, 2022

Deploy Preview for volto ready!

Name Link
🔨 Latest commit e27a301
🔍 Latest deploy log https://app.netlify.com/sites/volto/deploys/63972036c545f70009ec01de
😎 Deploy Preview https://deploy-preview-4085--volto.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@erral erral self-requested a review December 11, 2022 21:43
Copy link
Sponsor Member

@erral erral left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't we change the original string instead of modifying the English translation? Otherwise we will only have these 2 strings translated.

@sneridagh
Copy link
Member

@mpeeters I agree with @erral here. Could you please take a look? I'd like to merge it asap, today is the day!

@jimbiscuit
Copy link
Contributor

jimbiscuit commented Dec 12, 2022

@sneridagh I fix the defaultMessage in the component and remove the translation in po file

@erral erral self-requested a review December 12, 2022 13:30
@sneridagh sneridagh merged commit 3077633 into plone:master Dec 12, 2022
sneridagh pushed a commit that referenced this pull request Dec 12, 2022
…4085)

Co-authored-by: jimbiscuit <julienchandelle@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants