-
-
Notifications
You must be signed in to change notification settings - Fork 610
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix typo in english translation and add missing french translation #4085
Conversation
✅ Deploy Preview for volto ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't we change the original string instead of modifying the English translation? Otherwise we will only have these 2 strings translated.
@sneridagh I fix the defaultMessage in the component and remove the translation in po file |
…4085) Co-authored-by: jimbiscuit <julienchandelle@gmail.com>
No description provided.