(fix): Paste button disappearing while coping from nested blocks #4505
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for volto canceled.
|
Passing run #4372 ↗︎
Details:
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. |
|||||||||||||||
tiberiuichim
approved these changes
Mar 12, 2023
sneridagh
pushed a commit
that referenced
this pull request
Mar 15, 2023
Co-authored-by: Tiberiu Ichim <tiberiuichim@users.noreply.github.com>
sneridagh
added a commit
that referenced
this pull request
Mar 15, 2023
…) (#4530) Co-authored-by: dobri1408 <50819975+dobri1408@users.noreply.github.com> Co-authored-by: Tiberiu Ichim <tiberiuichim@users.noreply.github.com>
erral
pushed a commit
that referenced
this pull request
Mar 18, 2023
Co-authored-by: Tiberiu Ichim <tiberiuichim@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
screen-capture.1.webm
I discovered that if you try to copy from a block with other blocks in it, like EEA volto-accordion-block or EEA volto-columns-block and paste outside, the paste button disappears. This is due to the Plug component not rendering. I saw that setting the "dependencies" property, to selectedBlock, makes the Plug rerender. This can't be tested with a clean volto without addons, because there is not a pre-built block that has other blocks in it