Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Environment variables need to be properly documented #4581

Open
tiberiuichim opened this issue Mar 21, 2023 · 13 comments · May be fixed by #5735
Open

Environment variables need to be properly documented #4581

tiberiuichim opened this issue Mar 21, 2023 · 13 comments · May be fixed by #5735

Comments

@tiberiuichim
Copy link
Contributor

process.env.RAZZLE_DEV_PROXY_API_PATH ||
process.env.RAZZLE_INTERNAL_API_PATH ||
process.env.RAZZLE_API_PATH ||

@tiberiuichim
Copy link
Contributor Author

tiberiuichim commented Mar 21, 2023

Follow the pattern of documenting environment variables as shown in https://6.docs.plone.org/volto/configuration/environmentvariables.html

@KIET7UKE

This comment was marked as resolved.

@mjavedcoder

This comment was marked as resolved.

@stevepiercy

This comment was marked as outdated.

@harshlancer
Copy link

As these are runtime variable and as the docs suggest these should be documented like
yarn build && RAZZLE_API_PATH=https://plone.org yarn start:prod
Right?

@AAYUSH-droid

This comment was marked as resolved.

@stevepiercy

This comment was marked as resolved.

@hasnaat-iftikhar

This comment was marked as resolved.

@stevepiercy

This comment was marked as resolved.

@Akshat2Jain
Copy link
Member

Akshat2Jain commented Sep 25, 2023

Hey @stevepiercy can you guide me a little in this?

@stevepiercy
Copy link
Collaborator

@Akshat2Jain sorry, I don't know. I would suggest you look at what @tiberiuichim posted and referenced, and try to figure it out from there, and if it is still not clear, then ask him as he created this issue.

@stevepiercy
Copy link
Collaborator

stevepiercy commented Feb 6, 2024

I think we need to overhaul this page before we let contributors move forward with a PR. Environment variables

For example, we don't need to refer to obsolete things here, only current things. The obsolete stuff goes into the upgrade guide.

I also would like to have settings in a sorted definition list, instead of headings for each. We can group together some settings in categories under a heading as needed.

@tiberiuichim what do you think?

@tiberiuichim
Copy link
Contributor Author

@stevepiercy +1 on your proposal

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Todo
Status: No status
Development

Successfully merging a pull request may close this issue.

8 participants