Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

a11y - sharing page - search icon label - cms ui #5124

Closed
Wagner3UB opened this issue Aug 24, 2023 · 2 comments · Fixed by #5224
Closed

a11y - sharing page - search icon label - cms ui #5124

Wagner3UB opened this issue Aug 24, 2023 · 2 comments · Fixed by #5224
Labels
01 type: bug
Projects
Accessibility RedTurtle priorities

Comments

@Wagner3UB
Copy link
Contributor

Describe the bug

  • Search icon doesn't have label

To Reproduce

  • inspect the icon or using a screen reader
    <button class="ui icon button"><i aria-hidden="true" class="search icon"></i></button>

Screenshots
Schermata 2023-08-24 alle 16 44 07
ts

Software (please complete the following information):

Volto Version 17.0.0-alpha.19
Plone Version 6.0.4

Additional context
Add any other context about the problem here.
@Wagner3UB Wagner3UB added this to To do in RedTurtle priorities via automation Aug 24, 2023
@Wagner3UB Wagner3UB added this to To do in Accessibility via automation Aug 24, 2023
@AdarshRawat1
Copy link
Member

@Wagner3UB, Allow me to tackle this issue.

ZubairImtiaz3 added a commit to ZubairImtiaz3/volto that referenced this issue Sep 23, 2023
@ZubairImtiaz3
Add arial label to search. fixes plone#5124
3b8b535
@ZubairImtiaz3 ZubairImtiaz3 mentioned this issue Sep 23, 2023
Merged
Accessibility automation moved this from To do to Done Sep 26, 2023
davisagli pushed a commit that referenced this issue Sep 26, 2023
@ZubairImtiaz3
(fixes #5124) Enhance Accessibility, Add aria-label to search. (#5224)
039db7d
RedTurtle priorities automation moved this from To do to Done Sep 26, 2023
sneridagh added a commit that referenced this issue Sep 26, 2023
@sneridagh
Merge branch 'master' into improveslugs
9c8740e 
* master:
  fix preview image (#5153)
  fixed deprecated buffer.from (#5205)
  feat: add canonical link (#5215)
  Fix links to link integrity in delete modal (#5226)
  (fixes #5124) Enhance Accessibility, Add aria-label to search.  (#5224)
  document the querystringSearchGet setting (#5206)
  Fix empty slate text block in table of contents (#5156)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
01 type: bug
Projects
Accessibility
  
Done
RedTurtle priorities
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

(fixes #5124) Enhance Accessibility, Add aria-label to search. ZubairImtiaz3/volto
3 participants
@Wagner3UB @AdarshRawat1 and others