Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

A small typo in contributing-core.md file #5537

Closed
ujjwaleee26 opened this issue Dec 15, 2023 · 1 comment
Closed

A small typo in contributing-core.md file #5537

ujjwaleee26 opened this issue Dec 15, 2023 · 1 comment
Labels
01 type: bug

Comments

@ujjwaleee26
Copy link
Contributor

the pnp typo command does not work . Should be chnaged to pnpm
Screenshot 2023-12-15 at 5 46 44 PM
@plone plone deleted a comment from aarishshahmohsin Dec 15, 2023
@plone plone deleted a comment from aarishshahmohsin Dec 15, 2023
@plone plone deleted a comment from ujjwaleee26 Dec 15, 2023
@stevepiercy
Copy link
Collaborator

@ujjwaleee26 see https://6.docs.plone.org/contributing/first-time.html#write-code for how to avoid the problem you had with your PR.

davisagli pushed a commit that referenced this issue Dec 16, 2023
@ujjwaleee26
fix- #5537 (#5539)
10014f8
@davisagli davisagli mentioned this issue Dec 16, 2023
Merged
pranayjoshi pushed a commit to pranayjoshi/volto that referenced this issue Dec 20, 2023
@ujjwaleee26 @pranayjoshi
fix- plone#5537 (plone#5539)
1845fc7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
01 type: bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@davisagli @stevepiercy @ujjwaleee26