Multilingual redirector does not take into account the stored cookie in SSR

[sneridagh]

Describe the bug
A clear and concise description of what the bug is.

To Reproduce
Steps to reproduce the behavior:

1. As anonymous user/admin
2. In a multilingual setup, (eg. EN/DE), go to 'http://localhost:3000/' (root)
3. Click on the language switcher to EN
4. Load again http://localhost:3000/ (no /de or /en, not navigating, in SSR, first request)
5. Actual behavior: the site redirects to /de always (default language set)

Expected behavior
The site redirects to /en (the value that is stored in the language cookie, since we went to /en in the beginning)

[robgietema]

I can not reproduce this error, for me this works (both in Volto and in client projects).

[robgietema]

The issue is that the language selector checks if the language set by the cookie (in this case EN) is different from the language from the content object (in this case the root is set to DE). When it is different it sets the cookie to the language of the content object. What needs to be changed to fix this is either don't do this check on the siteroot or make the siteroot language independent and don't set the cookie if the langage is not set for the content object.

[robgietema]

#5665

[sneridagh]

Holly F.... ok, got it. Merged!

I guess that a quick fix is to remove the lang from the Plone Site Root DX type. Meh.

Thanks for looking into it!