Add Vite (client only, no SSR) build. Update Next.js 14.2.2 and Remix to 2.8.0 #5970

sneridagh · 2024-04-20T00:09:05Z

No description provided.

… Build cached option to speedup operations.

* main: Improvements to the monorepo setup with utilities, especially ESLint.… (#5969) DEV: put nvm installation section into a separate include file (#5968)

netlify · 2024-04-20T00:09:23Z

✅ Deploy Preview for volto canceled.

Name	Link
🔨 Latest commit	`c1ae7d2`
🔍 Latest deploy log	https://app.netlify.com/sites/volto/deploys/662a0cc444dbbc0008724e3c

netlify · 2024-04-20T00:09:23Z

✅ Deploy Preview for plone-components canceled.

Name	Link
🔨 Latest commit	`c1ae7d2`
🔍 Latest deploy log	https://app.netlify.com/sites/plone-components/deploys/662a0cc46f2021000808ab80

stevepiercy

Docs LGTM. Thank you!

sneridagh · 2024-04-24T09:01:10Z

@stevepiercy I added some more docs to the core developer section, could you please do a quick check?

stevepiercy

Mostly nitpicky stuff, but one question needs verification regarding Yeoman usage in the generator.

stevepiercy · 2024-04-24T17:13:54Z

docs/source/contributing/developing-core.md

@@ -289,21 +289,59 @@ Used by Volto, you can also use it in other JavaScript frameworks and environmen
 ## Supported frameworks

 Plone supports several frontend implementations, the main one being Volto as the default frontend and reference React-based implementation.


Suggested change

Plone supports several frontend implementations, the main one being Volto as the default frontend and reference React-based implementation.

Plone supports several frontend {term}`reference implementation`s.

Volto, a React-based reference implementation, is the default frontend for Plone 6.

@stevepiercy I'd like to start using the "reference implementation" concept here and there. We talked about it during the sprint, if you think that the wording is not correct and we should find a better one, let's do it, but I'd like to convey this from now on for Volto and Classic.

Oh, I thought it was a mistake, not intentional. In that case the term is "reference implementation" and should not have other terms inserted within. I updated my suggestion accordingly.

I added the term to the Documentation glossary in plone/documentation#1656.

docs/source/contributing/developing-core.md

stevepiercy · 2024-04-24T17:20:24Z

docs/source/contributing/developing-core.md

+The others are currently under heavy development, marked as experimental and for now, they remain as a proof of concept.
+Although they do work now in an acceptable way, the implementation might change in the future.
+Please note that these implementations only show how to access the public Plone content in the current site and dealing with data fetching and routing.
+They use the Plone Frontend Strategic Packages (`@plone/registry`, `@plone/client`, `@plone/components`, etc).

 ### Plone

 The default frontend and reference React-based implementation in Plone is Volto.


Suggested change

The default frontend and reference React-based implementation in Plone is Volto.

Volto is the default frontend for Plone 6.

It is a React-based {term}`reference implementation`.

Same as above

Suggestion updated.

docs/source/contributing/developing-core.md

Co-authored-by: Steve Piercy <web@stevepiercy.com>

sneridagh · 2024-04-24T17:39:42Z

@stevepiercy please take a look at my comments above.

See plone/volto#5970

stevepiercy

Ready to merge, pending my updated suggestions.

stevepiercy · 2024-04-25T08:02:30Z

If the readme-link-check build fails, it is due to a temporary outage of https://plone.org.br/ See https://github.com/plone/volto/actions/runs/8828868089/job/24238689105#step:4:143

* main: (49 commits) Update to Plone 6.0.11 (#5989) Defines the last 4 parameters of the `asyncConnect` function with optional (#5986) Flexibilize the pins for all ESlint deps, in Volto and generators (#5991) Release 18.0.0-alpha.29 Release @plone/types 1.0.0-alpha.11 fix: pass down locale to IntlProvider (#5976) Add Vite (client only, no SSR) build. Update Next.js 14.2.2 and Remix to 2.8.0 (#5970) Fix no router link in logo (#5981) Improve postinstall script, building all the deps (#5980) Better BlocksData types (#5979) Add missing types ts fields Release 18.0.0-alpha.28 Release @plone/slate 18.0.0-alpha.12 Release @plone/registry 1.5.6 Improvements to the monorepo setup with utilities, especially ESLint.… (#5969) DEV: put nvm installation section into a separate include file (#5968) Bundle optimization (#5295) [client] Move provider to own package - Use parcel - `@plone/providers` (#5887) Fix flaky test 'As editor I can add links' by using getSlateEditorAndType (#5966) Fix rendering if ConditionalLink has no children (#5963) ...

* main: (1206 commits) Allow Makefile to be modified by Makefile.local if present (#5997) Cypress replaced wait with assertions (#5998) Replace spinner with Progress bar and fix it's position . (#5620) (#5929) Fix type for component registry components (#6002) Fix 301 and 302 redirects. (#5999) Release 18.0.0-alpha.30 Force add .d.ts files to releaser Release generate-volto 9.0.0-alpha.15 Fix server side sidebar rendering (#5993) Cleaned up useless injectIntl in DefaultView (#5995) Fix image disappears after pressing the Enter key on title field in i… (#5975) Update to Plone 6.0.11 (#5989) Defines the last 4 parameters of the `asyncConnect` function with optional (#5986) Flexibilize the pins for all ESlint deps, in Volto and generators (#5991) Release 18.0.0-alpha.29 Release @plone/types 1.0.0-alpha.11 fix: pass down locale to IntlProvider (#5976) Add Vite (client only, no SSR) build. Update Next.js 14.2.2 and Remix to 2.8.0 (#5970) Fix no router link in logo (#5981) Improve postinstall script, building all the deps (#5980) ...

sneridagh added 6 commits April 19, 2024 12:36

Improvements to the monorepo setup with utilities, especially ESLint.…

f46e4f6

… Build cached option to speedup operations.

Changelog

69fab4f

update nextjs

7c5da4e

Update Remix to latest

f3caf8d

Add Vite build (no SSR)

8b66287

Merge branch 'main' into updatedepspocs

1eaab5b

* main: Improvements to the monorepo setup with utilities, especially ESLint.… (#5969) DEV: put nvm installation section into a separate include file (#5968)

sneridagh added 2 commits April 19, 2024 18:21

Prettier ignore

bf8ab5e

Fix Remix

b67845b

stevepiercy approved these changes Apr 21, 2024

View reviewed changes

sneridagh added 2 commits April 23, 2024 10:26

Update docs

17dcad5

Add some docs

97c56b4

sneridagh requested a review from stevepiercy April 24, 2024 09:01

stevepiercy requested changes Apr 24, 2024

View reviewed changes

Apply suggestions from code review

1cbcb66

Co-authored-by: Steve Piercy <web@stevepiercy.com>

stevepiercy added a commit to plone/documentation that referenced this pull request Apr 24, 2024

Add reference implementation to the glossary.

daa676a

See plone/volto#5970

stevepiercy mentioned this pull request Apr 24, 2024

Add reference implementation to the glossary. plone/documentation#1656

Merged

stevepiercy approved these changes Apr 24, 2024

View reviewed changes

stevepiercy and others added 6 commits April 25, 2024 00:18

Restructure frontends into Supported and Experimental

dcde3c6

Merge branch 'main' into updatedepspocs

d7421d0

Pin myst-parser

f7f84e5

Changelog

9709ef3

Fix syntax of netlify.toml headers.values

297c2cc

Remove pin of myst-parser to try auto-resolution

c1ae7d2

sneridagh merged commit 5d4338f into main Apr 25, 2024
73 of 74 checks passed

sneridagh deleted the updatedepspocs branch April 25, 2024 08:34

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add Vite (client only, no SSR) build. Update Next.js 14.2.2 and Remix to 2.8.0 #5970

Add Vite (client only, no SSR) build. Update Next.js 14.2.2 and Remix to 2.8.0 #5970

sneridagh commented Apr 20, 2024

netlify bot commented Apr 20, 2024 •

edited

netlify bot commented Apr 20, 2024 •

edited

stevepiercy left a comment

sneridagh commented Apr 24, 2024

stevepiercy left a comment

stevepiercy Apr 24, 2024 •

edited

sneridagh Apr 24, 2024 •

edited

stevepiercy Apr 24, 2024

stevepiercy Apr 24, 2024 •

edited

sneridagh Apr 24, 2024

stevepiercy Apr 24, 2024

sneridagh commented Apr 24, 2024

stevepiercy left a comment

stevepiercy commented Apr 25, 2024

		@@ -289,21 +289,59 @@ Used by Volto, you can also use it in other JavaScript frameworks and environmen
		## Supported frameworks

		Plone supports several frontend implementations, the main one being Volto as the default frontend and reference React-based implementation.

	Plone supports several frontend implementations, the main one being Volto as the default frontend and reference React-based implementation.
	Plone supports several frontend {term}`reference implementation`s.
	Volto, a React-based reference implementation, is the default frontend for Plone 6.

	The default frontend and reference React-based implementation in Plone is Volto.
	Volto is the default frontend for Plone 6.
	It is a React-based {term}`reference implementation`.

Add Vite (client only, no SSR) build. Update Next.js 14.2.2 and Remix to 2.8.0 #5970

Add Vite (client only, no SSR) build. Update Next.js 14.2.2 and Remix to 2.8.0 #5970

Conversation

sneridagh commented Apr 20, 2024

netlify bot commented Apr 20, 2024 • edited

✅ Deploy Preview for volto canceled.

netlify bot commented Apr 20, 2024 • edited

✅ Deploy Preview for plone-components canceled.

stevepiercy left a comment

Choose a reason for hiding this comment

sneridagh commented Apr 24, 2024

stevepiercy left a comment

Choose a reason for hiding this comment

stevepiercy Apr 24, 2024 • edited

Choose a reason for hiding this comment

sneridagh Apr 24, 2024 • edited

Choose a reason for hiding this comment

stevepiercy Apr 24, 2024

Choose a reason for hiding this comment

stevepiercy Apr 24, 2024 • edited

Choose a reason for hiding this comment

sneridagh Apr 24, 2024

Choose a reason for hiding this comment

stevepiercy Apr 24, 2024

Choose a reason for hiding this comment

sneridagh commented Apr 24, 2024

stevepiercy left a comment

Choose a reason for hiding this comment

stevepiercy commented Apr 25, 2024

netlify bot commented Apr 20, 2024 •

edited

netlify bot commented Apr 20, 2024 •

edited

stevepiercy Apr 24, 2024 •

edited

sneridagh Apr 24, 2024 •

edited

stevepiercy Apr 24, 2024 •

edited