Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEV: put nvm installation section into a separate include file #5968

Merged
merged 3 commits into from
Apr 19, 2024

Conversation

animus888
Copy link
Contributor

No description provided.

Copy link

netlify bot commented Apr 19, 2024

Deploy Preview for plone-components canceled.

Name Link
🔨 Latest commit 43faa3a
🔍 Latest deploy log https://app.netlify.com/sites/plone-components/deploys/66229439ea6ebd0008795484

Copy link

netlify bot commented Apr 19, 2024

Deploy Preview for volto ready!

Name Link
🔨 Latest commit 43faa3a
🔍 Latest deploy log https://app.netlify.com/sites/volto/deploys/6622943936b4ea0008c6ec3c
😎 Deploy Preview https://deploy-preview-5968--volto.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Collaborator

@stevepiercy stevepiercy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@stevepiercy
Copy link
Collaborator

@animus888 this looks ready to me. Is there a reason you put it in draft state? It can be merged right away.

@animus888 animus888 marked this pull request as ready for review April 19, 2024 17:31
@animus888
Copy link
Contributor Author

@animus888 this looks ready to me. Is there a reason you put it in draft state? It can be merged right away.

@stevepiercy yes, I already changed the state from draft to ready.

@stevepiercy stevepiercy merged commit c7de2e9 into plone:main Apr 19, 2024
48 checks passed
sneridagh added a commit that referenced this pull request Apr 20, 2024
* main:
  Improvements to the monorepo setup with utilities, especially ESLint.… (#5969)
  DEV: put nvm installation section into a separate include file (#5968)
sneridagh added a commit that referenced this pull request Apr 29, 2024
* main: (49 commits)
  Update to Plone 6.0.11 (#5989)
  Defines the last 4 parameters of the `asyncConnect` function with optional (#5986)
  Flexibilize the pins for all ESlint deps, in Volto and generators (#5991)
  Release 18.0.0-alpha.29
  Release @plone/types 1.0.0-alpha.11
  fix: pass down locale to IntlProvider (#5976)
  Add Vite (client only, no SSR) build. Update Next.js 14.2.2 and Remix to 2.8.0 (#5970)
  Fix no router link in logo (#5981)
  Improve postinstall script, building all the deps (#5980)
  Better BlocksData types (#5979)
  Add missing types ts fields
  Release 18.0.0-alpha.28
  Release @plone/slate 18.0.0-alpha.12
  Release @plone/registry 1.5.6
  Improvements to the monorepo setup with utilities, especially ESLint.… (#5969)
  DEV: put nvm installation section into a separate include file (#5968)
  Bundle optimization (#5295)
  [client] Move provider to own package - Use parcel - `@plone/providers` (#5887)
  Fix flaky test 'As editor I can add links' by using getSlateEditorAndType (#5966)
  Fix rendering if ConditionalLink has no children (#5963)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants