Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the ObjectBrowser for creating links in text editor #1240

Closed
wants to merge 6 commits into from

Conversation

frapell
Copy link
Sponsor Member

@frapell frapell commented Feb 26, 2020

This is coming from #1098

@frapell
Copy link
Sponsor Member Author

frapell commented Feb 26, 2020

@sneridagh Can you take a look and share your thoughts?

@sneridagh
Copy link
Member

@frapell nice! yeah, we are looking something like this. @pnicolli and the RT folks are also looking for a UX formula that works like this.

The only thing missing is how we provide a way to specify external URLs, and if we want to maintain the "lite inline chooser" in some manner.

Do you have something in mind for that?

I have to contact @albertcasado for searching a good UX solution for it.

We have to discuss this in the next weeks, I will include you in the meetings/discussions!

@frapell
Copy link
Sponsor Member Author

frapell commented Feb 26, 2020

@sneridagh Ahhh... totally ignored that use case... I am no UX/UI designer, so not sure the best approach...

One way could be maybe to keep the AddLinkForm, without the search capability, and instead add the "navTreeSVG" button to the left of it... That way you can type any URL you want, but also you can click this button to navigate using the ObjectBrowser...

For sure, let me know if you are meeting, I could ask our UX/UI guy to join me and share some ideas!

@frapell
Copy link
Sponsor Member Author

frapell commented Feb 26, 2020

@sneridagh Also, btw, I think that when you highlight an existing link, you should get under the block sidebar all of the different controls for it, like the target, title, WCAG, etc... Something like the Image block has...

@sneridagh
Copy link
Member

@frapell I almost forgot! This is the PR with RT folks current work: #1223

We should definitely sum efforts!

@frapell
Copy link
Sponsor Member Author

frapell commented Feb 26, 2020

@sneridagh LOL, seems they indeed added the navTreeSVG to the AddLinkForm XD

I guess we can discard this then, and continue on that branch ;)

@sneridagh
Copy link
Member

It’s great to have different PoCs, so we can decide having different options.

Anyways, I will contact Albert, let’s see what’s his take on this. Then we can schedule a meeting together to decide the final approach.

/cc @pnicoli @tisto @cekk @giuliaghisini

@tiberiuichim
Copy link
Contributor

Closing in favour of #1223

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants