Make build dirs parameterizable via BUILD_DIR new runtime env var #3087
Conversation
|
✔️ Deploy Preview for volto ready! 🔨 Explore the source changes: e12b3a3 🔍 Inspect the deploy log: https://app.netlify.com/sites/volto/deploys/6213521e258f9400082c5a95 😎 Browse the preview: https://deploy-preview-3087--volto.netlify.app/configuration/environmentvariables.html |
* master: Proper directory where run the docs. Disable docs-linkcheckbroken for now Fix Python version in docs.yml GHA Plone 6 docs (#3001)
| !!! important | ||
| `ADDONS` does *not* work for development packages, which are *always* enabled if defined in your `jsconfig.json` or via `mrs.developer.json`. | ||
| ```{important} | ||
| `ADDONS` does *not* work for development packages, which are *always* enabled if defined in your `jsconfig.json` or via `mrs.developer.json`. |
There was a problem hiding this comment.
I find this line misleading. ADDONS shouldn't care if an addon comes from node_modules or is aliased via jsconfig.
I think the message is "The ADDONS key is a Volto specific configuration. Simply setting ADDONS doesn't download the javascript package. This has to be covered by another way, either installing the addon package (with yarn add) or loading it as a development package with mrs-developer.
There was a problem hiding this comment.
I wanted to state clearly that a developer add-on is always enabled, if declared in mrs-developer and thus, in jsconfig.js. I'll try to merge both ideas.
There was a problem hiding this comment.
but maybe that clarification has to be done elsewhere, not referred to ADDONS env var...
* master: Improve flaky test (#3089)
Since Volto is parameterizable on runtime, it's been a while since I wanted to do this.
So, on release, it will create a plain build and upload it to the repo in the
distfolder.The build supposed before this PR that it was going to be in
buildalways. Now you can parameterize with:BUILD_DIRruntime env var. In case you want to run from somewhere else.or
Unfortunately, the initial yarn install is required still... :(
/cc @avoinea @ericof I hope this eases even more the Docker image builds.