Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update simple.md #3159

Closed
wants to merge 5 commits into from
Closed

Conversation

MdSahil-oss
Copy link
Contributor

What this PR Does ?
fixes #3157

What this PR Does ?
fixes #3157
@netlify
Copy link

netlify bot commented Mar 15, 2022

Deploy Preview for volto ready!

Name Link
🔨 Latest commit 22caee9
🔍 Latest deploy log https://app.netlify.com/sites/volto/deploys/626046705d2ff700086c5a59
😎 Deploy Preview https://deploy-preview-3159--volto.netlify.app/deploying/simple.html
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@MdSahil-oss MdSahil-oss requested a review from tisto March 15, 2022 15:14
@sneridagh
Copy link
Member

sneridagh commented Mar 15, 2022

@MdSahil-oss https://plone.org/community/gsoc/2022/ideas

Note: we think trying to fix easy issues is a nice way to start learning about the Plone development process, but we are not necessarily expecting a pull request from you, if you have something valuable to contribute, that's very nice, but if that's not the case, that is totally fine and we will not misconsider your GSoC application for that. Also, if you do have an interesting PR, be aware review and merge might take time as the core contributors can be busy.

also, by fixing documentation I have no clue if you are able to tackle complex JS issues or problems or if you know ReactJS to complete a successful GSOC.

Btw, this fix is not correct, it should be:

    location ~ / {
        location ~* \.(js|jsx|css|less|swf|eot|ttf|otf|woff|woff2)$ {
            add_header Cache-Control "public";
            expires +1y;
            proxy_pass http://volto;
        }
        location ~* static.*\.(ico|jpg|jpeg|png|gif|svg)$ {
            add_header Cache-Control "public";
            expires +1y;
            proxy_pass http://volto;
        }

        proxy_set_header        Host $host;
        proxy_set_header        X-Real-IP $remote_addr;
        proxy_set_header        X-Forwarded-For $proxy_add_x_forwarded_for;
        proxy_set_header        X-Forwarded-Proto $scheme;
        proxy_redirect http:// https://;
        proxy_pass http://volto;
    }

@MdSahil-oss
Copy link
Contributor Author

@sneridagh Done! as per your suggestion

@stevepiercy
Copy link
Collaborator

@MdSahil-oss please add a changelog entry. Every pull request in this repo requires one.

CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Show resolved Hide resolved
docs/source/deploying/simple.md Outdated Show resolved Hide resolved
@stevepiercy
Copy link
Collaborator

@MdSahil-oss this PR cannot be merged in its current state. Please resolve #3159 (review), and merge master into your branch and push, which should also resolve the merge conflict that is blocking the merge. Thank you!

@MdSahil-oss
Copy link
Contributor Author

@MdSahil-oss this PR cannot be merged in its current state. Please resolve #3159 (review), and merge master into your branch and push, which should also resolve the merge conflict that is blocking the merge. Thank you!

@stevepiercy because of some issues, Let me close this PR first and creating a new PR for this issue.

@stevepiercy stevepiercy deleted the balance-Curly-braces-in-simple.md branch May 16, 2022 00:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error on the simple deployment documentation nginx snippet
3 participants