Support Node 18 #3699
Support Node 18 #3699
Conversation
✅ Deploy Preview for volto canceled.
|
|
Test summaryRun details
View run in Cypress Dashboard ➡️ This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
|
I'm using Volto on node 18 for a while, didn't notice any issue |
|
Tests failing ref: webpack/webpack#14532 |
* master: (23 commits) The listing block icon has been improved to avoid confusions with the normal text list (#3785) Fix autocomplete widget with an empty search result (#3757) Back to development Release 16.0.0-alpha.43 Prepare for release Upgrade dependency rrule (optional dependency luxon removed) (#3781) Fix logout to stay on the same page where the user was (#3739) Object browser: image search should only show images (#3738) Update CHANGELOG.md Update changelog Update branch, docs location add dutch translations Trigger on 6-dev Fix spelling Add action to trigger Plone documentation update Fixed typo for ordinal number at spanish translation Fixed some typos for spanish translation Fixed a msg string translation Fixed a msg string translation Updated spanish translation ...
|
This is pitiful: webpack/webpack#14532 (comment) I investigated it a bit. It seems that they won't fix Webpack 4. Either we go full length and upgrade to 5, or we cope with Great, and it seems that the option is invalid for NodeJS < 18 ... Node 18 is LTS in 2022-10-25 :/ /cc @plone/volto-team @davisagli |
|
@sneridagh I guess we need both: for the short term, add |
|
We added support for Node 18 in #4086 instead. |
It will be LTS on 2022-10-25, better get prepared.
It seems to me that it's a bit cumbersome that time of the year that we support up to 3 Node versions (Oct-Apr) when 14 will be deprecated... it's CI time nonetheless...
Maybe something we can talk during the conference. /cc @plone/volto-team