Refactor Sharing #4918
Draft
Refactor Sharing #4918
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for volto canceled.
|
9 failed tests on run #5921 ↗︎
Details:
|
|||||||||||||||||||||||||||||||||||||||||||||
| Test | Artifacts | |
|---|---|---|
| Login Tests > As registered user I can login |
Output
Screenshots
Video
|
|
sharing.js • 1 failed test • Core 18.x
| Test | Artifacts | |
|---|---|---|
| Sharing Tests > As editor, I can share a page to another user |
Output
Screenshots
Video
|
|
login.js • 1 failed test • Core Basic - Plone 5
| Test | Artifacts | |
|---|---|---|
| Login Tests > As registered user I can login |
Output
Screenshots
Video
|
|
sharing.js • 1 failed test • Core Basic - Plone 5
| Test | Artifacts | |
|---|---|---|
| Sharing Tests > As editor, I can share a page to another user |
Output
Screenshots
Video
|
|
sharing.js • 1 failed test • Seamless
| Test | Artifacts | |
|---|---|---|
| Sharing Tests > As editor, I can share a page to another user |
Output
Screenshots
Video
|
|
The first 5 failed specs are shown, see all 9 specs in Cypress Cloud.
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.
nileshgulia1
requested changes
Jun 26, 2023
| this.setState({ isClient: true }); | ||
| } | ||
| useEffect(() => { | ||
| dispatch(getSharing(getBaseUrl(pathname), search)); |
There was a problem hiding this comment.
Beware of lifecycle changes. The toast is only displayed if the request is successfully loaded. we probably don't need any other entry to dep. array other than this.
| }; | ||
| }), | ||
| useEffect(() => { | ||
| map(props_entries, (entry) => { |
There was a problem hiding this comment.
This should be moved in previous useEffect under the condition. https://github.com/plone/volto/pull/4918/files#r1241902386
| */ | ||
| onSubmit(event) { | ||
| useEffect(() => { | ||
| setInherit(props_inherit === null ? inherit : props_inherit); |
There was a problem hiding this comment.
same as previous. Should be moved inside a condition.
| const [inherit, setInherit] = useState(props_inherit); | ||
| const [isClient, setIsClient] = useState(false); | ||
| const [entries, setEntries] = useState(props_entries); | ||
| const pathname = props.location.pathname; |
There was a problem hiding this comment.
Suggested change
| const pathname = props.location.pathname; | |
| const { pathname } = useLocation() |
| const loading = useSelector((state) => state.content.get?.loading); | ||
| const loaded = useSelector((state) => state.content.get?.loaded); | ||
| const error = useSelector((state) => state.content.get?.error, shallowEqual); | ||
| const title = useSelector((state) => state.content.data?.title, shallowEqual); |
There was a problem hiding this comment.
I don't think we need an extra field for title, as we are exporting whole content.
93 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@nileshgulia1 @JeffersonBledsoe , if you could look over where it is going wrong