Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Login #4933

Merged
merged 27 commits into from Sep 11, 2023
Merged

Refactor Login #4933

merged 27 commits into from Sep 11, 2023

Conversation

Tishasoumya-02
Copy link
Contributor

@Tishasoumya-02 Tishasoumya-02 commented Jun 28, 2023

@netlify
Copy link

netlify bot commented Jun 28, 2023

Deploy Preview for volto ready!

Name Link
🔨 Latest commit cb79ba6
🔍 Latest deploy log https://app.netlify.com/sites/volto/deploys/64ff2aa2786a7900074a85ef
😎 Deploy Preview https://deploy-preview-4933--volto.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@cypress
Copy link

cypress bot commented Jun 28, 2023

Passing run #7154 ↗︎

0 577 20 0 Flakiness 0
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.

Details:

Merge branch 'master' into login-refactor
Project: Volto Commit: cb79ba69db
Status: Passed Duration: 16:11 💡
Started: Sep 11, 2023 2:59 PM Ended: Sep 11, 2023 3:16 PM

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

Copy link
Member

@nileshgulia1 nileshgulia1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Tishasoumya-02 Cypress is failing after we rebase with master.

@Tishasoumya-02 Tishasoumya-02 marked this pull request as draft August 8, 2023 05:50
@nileshgulia1 nileshgulia1 marked this pull request as ready for review August 22, 2023 11:17
* master: (25 commits)
  (feat):Update toc block entries (#5146)
  view cypress test (#5149)
  fix search block search results number (#5171)
  fix : RecursiveWidget is incorrectly translated (#4513)
  Bugfix : Responsive Error in login page  (#4309)
  Fix default template for content type which contains block with schem… (#5159)
  Updated Spanish translation (#5120)
  ContentRules add and edit forms for languages other than English (#5162)
  Fix SelectWidget throwing error when editing a recently created conte… (#5155)
  Don't show ``No value`` option in SelectWidget and ArrayWidget if default value is 0 (#5152)
  Fix storybook config for project generator. Add support for SCSS, upgrade to webpack 5 in there as well. (#5132)
  Fix linkcheckbroken 301 redirect to https://www.dlr.de/de (#5131)
  Release 17.0.0-alpha.25
  fix: Fix querystringResults subrequests id, to work properly in dupli… (#5071)
  Fix accessibility of the content folder buttons (#5101)
  Refactor Comment (#4874)
  Refactor Search Tags (#4873)
  Logout Refactor (#4860)
  Add www.dlr.de to README (#5112)
  Fix default toc renderer for nested entries (#5116)
  ...
@sneridagh
Copy link
Member

@nileshgulia1 @Tishasoumya-02 please take a look at my last commit, I solved an issue, tell me if you have any question, for now, I will merge when green.

@sneridagh sneridagh merged commit 244daf8 into master Sep 11, 2023
53 checks passed
@sneridagh sneridagh deleted the login-refactor branch September 11, 2023 15:58
sneridagh added a commit that referenced this pull request Sep 12, 2023
* master:
  Fix use of CSS modules in webpack 5 (#5165)
  fix back button on search block to update the search results for #4402 (#4879)
  Fix toc accessibility issue (#5058)
  Add external className to UniversalLink for external link. (#5110)
  Refactor Login (#4933)
  Refactor Messages (#4926)
  Refactor Navigation (#4876)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants