Refactor PersonalTool component #4954
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for volto canceled.
|
Passing run #7069 ↗︎
Details:
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. |
|||||||||||||||
93 tasks
Tishasoumya-02
requested review from
sneridagh,
nileshgulia1 and
JeffersonBledsoe
nileshgulia1
approved these changes
Jul 24, 2023
nileshgulia1
requested changes
Jul 24, 2023
There was a problem hiding this comment.
@Tishasoumya-02 I get this error while clicking on PeronsalTools "preferences ":
TypeError: setPushed is not a function
push
src/components/manage/Toolbar/PersonalTools.jsx:59
56 | }, [dispatch, userId]);
57 |
58 | const push = (selector) => {
> 59 | setPushed(true);
| ^ 60 | props.loadComponent(selector);
61 | };
nileshgulia1
approved these changes
Aug 23, 2023
sneridagh
approved these changes
Sep 19, 2023
erral
pushed a commit
that referenced
this pull request
Sep 19, 2023
Co-authored-by: Nilesh <nileshgulia@gmail.com>
sneridagh
added a commit
that referenced
this pull request
Sep 19, 2023
* master: (31 commits) Refactor Content Rename Model (#4971) Refactor Content Tags Modal (#4970) Refactor Content workflow Modal (#4969) Refactor Content Property Model (#4968) Refactor Sidebar (#4965) Refactor PersonalTool component (#4954) Fix standalone navigation action call if expander is set (#5197) Fix api convenience buildout build Fix instruction to fetch add-on from repo (#5196) Remove JSON files from being linted by ESlint, since it's not its pur… (#5194) Release generate-volto 7.0.0-alpha.8 Add missing empty lock to acceptance generator addon folder (#5193) Release generate-volto 7.0.0-alpha.7 Release 17.0.0-alpha.27 TypeScript support in core (#4662) Update delete content modal for link integrity (#4786) Add external className to slate Link view. (#5188) Release generate-volto 7.0.0-alpha.6 Fix addon i18n local command when executed outside the scope of a Volto project. (#5181) Release 17.0.0-alpha.26 ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#4460