Refactor Blocks/ToC/Edit component #4961
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for volto canceled.
|
Passing run #6779 ↗︎
Details:
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. |
|||||||||||||||
93 tasks
Tishasoumya-02
requested review from
sneridagh,
nileshgulia1 and
JeffersonBledsoe
nileshgulia1
approved these changes
Jul 25, 2023
iFlameing
reviewed
Aug 28, 2023
| {title} | ||
| </AnchorLink> | ||
| {mode === 'edit' ? ( | ||
| <a href={`#${slug}`}>{title}</a> |
There was a problem hiding this comment.
@Tishasoumya-02 What is the benefit of this code?
There was a problem hiding this comment.
@iFlameing I pushed this part in order to fix #5020. Ideally, we should not scroll in edit mode. @sneridagh Thoughts ?
iFlameing
reviewed
Aug 28, 2023
| @@ -16,7 +16,11 @@ const RenderMenuItems = ({ items }) => { | |||
| item && ( | |||
| <React.Fragment key={id}> | |||
| <Menu.Item className={`headline-${level}`}> | |||
| <AnchorLink href={`#${slug}`}>{title}</AnchorLink> | |||
| {mode === 'edit' ? ( | |||
| <a href={`#${slug}`}>{title}</a> | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#4460
Also fixes #5020