Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Sphinx toctree warnings from included CHANGELOG.md #5135
Fix Sphinx toctree warnings from included CHANGELOG.md #5135
Changes from 38 commits
43f8587
12a3799
4053915
62da88f
51f473e
43704f5
3f38187
093ced2
3f7d9ed
ece8016
76ae6c7
05bd87c
eb047ad
13d48dc
5296f17
c6e464d
a11c3aa
e488977
8ce51f2
7f4e43a
ef12d1f
b56739c
ba0eb72
13ade25
2698d87
c4755cc
486670a
49de905
49a0ae6
7ad349f
18b01a4
fca0d01
6d17458
b187a41
5ab0c9e
03c83fb
a81b5b4
ca0ecc3
b9bc0f8
24e8d24
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Large diffs are not rendered by default.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you can leave out the git add, git commit, and git push here. release-it already pushes a commit with the changes that are made during this hook.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TIL. Should I pull it out now, or let @sneridagh fiddle around with it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd move it to a makefile command (as the
corepackagebump
). In fact, thecorepackagebump
actions are similar to these ones.