Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show which pages will have broken links if you would delete an item. #5234

Merged
merged 15 commits into from Nov 7, 2023

Conversation

jaroel
Copy link
Member

@jaroel jaroel commented Sep 27, 2023

Needs plone/plone.restapi#1714
Looks like this:

Screenshot 2023-10-03 at 18 30 04

@netlify
Copy link

netlify bot commented Sep 27, 2023

Deploy Preview for volto ready!

Name Link
🔨 Latest commit c5ff9e8
🔍 Latest deploy log https://app.netlify.com/sites/volto/deploys/654a55ebad4e4d000823557c
😎 Deploy Preview https://deploy-preview-5234--volto.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@sneridagh
Copy link
Member

LGTM so far!

@jaroel
Copy link
Member Author

jaroel commented Sep 28, 2023

I need to add the link to links-to-item somewhere again :)

@jaroel jaroel changed the title Show which pages will have break links if you would delete an item. Show which pages will have broken links if you would delete an item. Sep 28, 2023
@sneridagh
Copy link
Member

plone.restapi == 9.1.2
plone.rest == 4.1.2
and we need a plone.app.linkintegrity release in order to be able to merge this.
A final 6.0.8 would be optimal though so we don't have to document anything.

/cc @tisto @mauritsvanrees @davisagli

Copy link
Member

@sneridagh sneridagh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! We need 6.0.8 released first!
Thanks @jaroel !!

@mauritsvanrees
Copy link
Sponsor Member

we need a plone.app.linkintegrity release in order to be able to merge this.

@sneridagh Do you mean a release that has plone/plone.app.linkintegrity#95 merged?
This is included in 4.0.3 (and 3.6.2 for Plone 5.2). Coredev uses this already.

@tisto You made a release, but the release commits and the tag are not on GitHub. Can you check please?

@sneridagh
Copy link
Member

@mauritsvanrees yep! oh ok, maybe something wrong happened with the release.

@tisto
Copy link
Sponsor Member

tisto commented Nov 6, 2023

@mauritsvanrees sorry about this. zest.releaser fails on my local machine all the time when trying to update the coredev versions.cfg. Then the "git push" fails...

@tisto
Copy link
Sponsor Member

tisto commented Nov 6, 2023

@mauritsvanrees I can't find the tag and changes on my laptop. Will go to the office and check there...

@tisto
Copy link
Sponsor Member

tisto commented Nov 6, 2023

@mauritsvanrees found the tag and commits and pushed it.

@mauritsvanrees
Copy link
Sponsor Member

Thanks @tisto!

@sneridagh sneridagh merged commit 992d036 into main Nov 7, 2023
51 checks passed
@sneridagh sneridagh deleted the linkintegrity-breaches branch November 7, 2023 16:39
sneridagh added a commit that referenced this pull request Nov 10, 2023
…5234)

Co-authored-by: Víctor Fernández de Alba <sneridagh@gmail.com>
sneridagh added a commit that referenced this pull request Nov 14, 2023
…5234)

Co-authored-by: Víctor Fernández de Alba <sneridagh@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

None yet

4 participants