Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PoC - Vite and Tanstack Router, Query and @plone/client in SSR mode. #5750

Merged
merged 15 commits into from
Feb 13, 2024

Conversation

sneridagh
Copy link
Member

No description provided.

Copy link

netlify bot commented Feb 11, 2024

Deploy Preview for volto canceled.

Name Link
🔨 Latest commit 732bd60
🔍 Latest deploy log https://app.netlify.com/sites/volto/deploys/65cb28468bf6c90008ecce80

Copy link

netlify bot commented Feb 11, 2024

Deploy Preview for plone-components canceled.

Name Link
🔨 Latest commit 732bd60
🔍 Latest deploy log https://app.netlify.com/sites/plone-components/deploys/65cb28468de8c000086f4136

Copy link
Collaborator

@stevepiercy stevepiercy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Docs please!

apps/vite/README.md Outdated Show resolved Hide resolved
apps/vite/README.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@stevepiercy stevepiercy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, minor grammar fixes and a link fix.

apps/vite-ssr/README.md Outdated Show resolved Hide resolved
apps/vite-ssr/README.md Outdated Show resolved Hide resolved
apps/vite-ssr/README.md Outdated Show resolved Hide resolved
Co-authored-by: Steve Piercy <web@stevepiercy.com>
Copy link
Collaborator

@stevepiercy stevepiercy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

README and CI looks good. Thank you!

@stevepiercy stevepiercy dismissed their stale review February 12, 2024 14:27

Approve readme and ci only

Copy link
Collaborator

@stevepiercy stevepiercy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch on nextjs/README.md. CI and README looks good.

Copy link
Collaborator

@stevepiercy stevepiercy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Try this to workaround the readme check failure.

If it works, then you can remove the whitelist item in the CI that you added in an attempt to get it to pass.

apps/nextjs/README.md Outdated Show resolved Hide resolved
@sneridagh
Copy link
Member Author

@stevepiercy it still fails...

@stevepiercy
Copy link
Collaborator

oh lol _ is not a legal character in a domain name, hence the failure.

This should fail, I hope, and if it does, then I will update the whitelist item.
@stevepiercy
Copy link
Collaborator

I learned to Internet this many years ago 0️⃣ . lol. All right, that readme is good to go now. Just needs a change log and update branch. Back to you @sneridagh.

@stevepiercy stevepiercy requested review from stevepiercy and removed request for stevepiercy February 13, 2024 08:37
@sneridagh sneridagh merged commit 6bff505 into main Feb 13, 2024
63 of 64 checks passed
@sneridagh sneridagh deleted the viteandtanstackrouter branch February 13, 2024 09:22
@sneridagh
Copy link
Member Author

@stevepiercy thanks!

sneridagh added a commit that referenced this pull request Feb 15, 2024
…bars-et-al

* main: (56 commits)
  Exclude chromewebstore from linkcheck (#5761)
  (feat):App extras exceptions (#5621)
  Add VOLTOCONFIG Env Var (#5752)
  PoC - Vite and Tanstack Router, Query and `@plone/client` in SSR mode. (#5750)
  Update links to Redux and React developer extensions for Chrome (#5757)
  Overhaul environment variables documentation (#5736)
  Mention what version the 'links and references' view was added (#5756)
  Add wait commands to flaky block-listing tests (#5753)
  Fix logging in test-acceptance-server commands (#5748)
  Replaced outdated diff with a link to the current `package.json` on t… (#5728)
  Listing Block render of initial results in SSR (#5689)
  Fix @plone/volto-slate path in moduleNameMapper (#5743)
  Added global form state. (#5721)
  Release generate-volto 9.0.0-alpha.5
  Fix tests in projects that involves TS files (#5738)
  Reorganize README, merging content into authoritative locations (#5511)
  Release 18.0.0-alpha.10
  Release generate-volto 9.0.0-alpha.4
  Release @plone/registry 1.2.2
  Enhance release in @plone/registry
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants