Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slots in core #5775

Merged
merged 75 commits into from
Feb 29, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
75 commits
Select commit Hold shift + click to select a range
d8b1eb5
API support for slots in registry
sneridagh Feb 16, 2024
fa39782
WIP SlotRenderer
sneridagh Feb 16, 2024
24babd7
First working implementation
sneridagh Feb 20, 2024
b58a977
Improve SlotRenderer
sneridagh Feb 20, 2024
9f5e56c
Changelog
sneridagh Feb 20, 2024
c2bd017
Merge branch 'main' into slots2024
sneridagh Feb 20, 2024
81dfe61
Improve and test as TS
sneridagh Feb 20, 2024
c2d859f
Better implementation, improve tests
sneridagh Feb 20, 2024
3a5d56b
Add coresandbox example, adjust here and there
sneridagh Feb 21, 2024
efc4805
Add ignore
sneridagh Feb 21, 2024
6bf883e
Use latest @types/react and @types/react-dom
sneridagh Feb 21, 2024
70c93f3
Temptative docs
sneridagh Feb 21, 2024
4ad1dd0
Merge branch 'main' into slots2024
sneridagh Feb 21, 2024
3f6ed67
Apply suggestions from code review
sneridagh Feb 22, 2024
829bea1
Update docs/source/configuration/slots.md
sneridagh Feb 22, 2024
4aba432
F*ck ts-jest, cannot wait to say bye to Jest
sneridagh Feb 22, 2024
3fbe33c
Change name of the
sneridagh Feb 22, 2024
0f013fc
Remove Semantic Container from coresandbox example
sneridagh Feb 22, 2024
3241e76
Add slots to toctree
stevepiercy Feb 22, 2024
8662ee4
Add https://stackoverflow.com to ignore in linkcheck, and sort entries
stevepiercy Feb 22, 2024
c4cfe86
Expound upon the slot tree structure and how it works with an ASCII tree
stevepiercy Feb 22, 2024
7e30c9d
Put the pending stuff into a todo, so that it sticks out like a sore …
stevepiercy Feb 22, 2024
520fc60
Put the predicates into a definition list (I changed my mind from a g…
stevepiercy Feb 22, 2024
1a9cb43
Create a new parent subsection for predicate helpers
stevepiercy Feb 22, 2024
a8f6de3
Tidy up `RouteCondition`
stevepiercy Feb 22, 2024
ffced49
Final pass, nitpicky stuff
stevepiercy Feb 22, 2024
f17ecbe
Fix TS tests
sneridagh Feb 22, 2024
6b98d6c
push locks
sneridagh Feb 22, 2024
675e0af
Finish the missing docs
sneridagh Feb 22, 2024
187e21e
Make ts-jest happy
sneridagh Feb 22, 2024
f189d85
Use a pattern of Type, required/optional, description for signatures.
stevepiercy Feb 22, 2024
e234d63
Grammar, no empty headings, tidy up
stevepiercy Feb 22, 2024
c9d6f9e
Merge remote-tracking branch 'origin/slots2024' into slots2024
stevepiercy Feb 22, 2024
b23bd9a
zero-indexed
stevepiercy Feb 22, 2024
2ad12dc
Add Cypress test
sneridagh Feb 22, 2024
6598127
Update docs/source/configuration/slots.md
sneridagh Feb 22, 2024
9bec47f
Force fresh build always
sneridagh Feb 22, 2024
5fde359
Force build on coresandbox
sneridagh Feb 22, 2024
c93d146
Revert "Force build on coresandbox"
sneridagh Feb 22, 2024
37e6b92
Remove methods that are not 18.x compatible :( (toReversed, toSplice)
sneridagh Feb 22, 2024
26d4dda
Add a small comment
sneridagh Feb 22, 2024
ac09167
Remove comments
sneridagh Feb 22, 2024
33b96c9
Merge branch 'main' into slots2024
sneridagh Feb 22, 2024
adec91d
Update docs/source/configuration/slots.md
stevepiercy Feb 24, 2024
049e16a
Link to API
stevepiercy Feb 24, 2024
547a677
Enhance intro sentence
stevepiercy Feb 24, 2024
3496942
s/inherited from/inspired by
stevepiercy Feb 24, 2024
594c5f9
Merge branch 'main' into slots2024
stevepiercy Feb 24, 2024
394622d
David's suggestions
sneridagh Feb 26, 2024
829ea91
Fix tests
sneridagh Feb 26, 2024
d73cb36
Add unit test
sneridagh Feb 26, 2024
ba356c3
Add navRoot to the equation, this enables Add form correct checks, an…
sneridagh Feb 26, 2024
b66b832
Add which slots are added by default in Volto
sneridagh Feb 26, 2024
589ed69
Refactor reorderSlotComponent to accommodate actions and targets
sneridagh Feb 26, 2024
2bb38c0
Fix tests
sneridagh Feb 26, 2024
cc40798
Jumpstart Volto glossary to include `predicates`. See #3344.
stevepiercy Feb 26, 2024
bcb5572
Revert. `make docs-livehtml` does not use Intersphinx, but `make docs…
stevepiercy Feb 26, 2024
c44c6a9
Fix tree diagram text and description of concepts
stevepiercy Feb 26, 2024
23e18a4
MyST syntax, move narrative text from heading, grammar fix.
stevepiercy Feb 26, 2024
70708ec
Revise descriptions of `reorderSlotComponent` and how its arguments w…
stevepiercy Feb 26, 2024
7030258
Merge branch 'main' into slots2024
stevepiercy Feb 26, 2024
fa44ecb
Steve better condition proposal
sneridagh Feb 27, 2024
8b37c10
Other better condition
sneridagh Feb 27, 2024
8ddb708
Tidy up code samples
stevepiercy Feb 28, 2024
cdfb28f
Consistent code samples
stevepiercy Feb 28, 2024
c8685f7
Overhaul Anatomy
stevepiercy Feb 28, 2024
18333ee
Merge branch 'main' into slots2024
stevepiercy Feb 28, 2024
40c1dfd
Rename slot name, and slot component's name and component
stevepiercy Feb 28, 2024
275b2c5
Rename other slot component's component
stevepiercy Feb 28, 2024
a35f373
Add a name for component in example
stevepiercy Feb 28, 2024
59a53fd
Enhance part about ordering slot components, and add targets to headings
stevepiercy Feb 28, 2024
6eea733
Restructure API docs to be more cohesive and contextual, specifically…
stevepiercy Feb 28, 2024
0942929
Align `reorderSlotComponent` description with earlier narrative text
stevepiercy Feb 28, 2024
2eae4b2
Reorder API methods so that they are in order of CRUD: create, get (r…
stevepiercy Feb 28, 2024
64c8c11
Revise per conference with Victor
stevepiercy Feb 29, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
5 changes: 3 additions & 2 deletions docs/source/conf.py
Original file line number Diff line number Diff line change
Expand Up @@ -91,10 +91,11 @@
# Ignore github.com pages with anchors
r"https://github.com/.*#.*",
# Ignore other specific anchors
r"https://developer.mozilla.org/en-US/docs/Web/HTTP/CORS/Errors#Identifying_the_issue",
r"https://docs.cypress.io/guides/references/migration-guide#Migrating-to-Cypress-version-10-0",
r"https://chromewebstore.google.com/detail/react-developer-tools/fmkadmapgofadopljbjfkapdkoienihi", # TODO retest with latest Sphinx when upgrading theme. chromewebstore recently changed its URL and has "too many redirects".
r"https://chromewebstore.google.com/detail/redux-devtools/lmhkpmbekcpmknklioeibfkpmmfibljd", # TODO retest with latest Sphinx when upgrading theme. chromewebstore recently changed its URL and has "too many redirects".
r"https://developer.mozilla.org/en-US/docs/Web/HTTP/CORS/Errors#Identifying_the_issue",
r"https://docs.cypress.io/guides/references/migration-guide#Migrating-to-Cypress-version-10-0",
r"https://stackoverflow.com", # volto and documentation # TODO retest with latest Sphinx.
]
linkcheck_anchors = True
linkcheck_timeout = 10
Expand Down
1 change: 1 addition & 0 deletions docs/source/configuration/index.md
Original file line number Diff line number Diff line change
Expand Up @@ -26,4 +26,5 @@ workingcopy
environmentvariables
expanders
locking
slots
```