Make dynamic/live teaser without additional requests #6024
+516
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for plone-components canceled.
|
❌ Deploy Preview for volto failed. Why did it fail? →
|
nileshgulia1
reviewed
Jun 2, 2024
|
|
||
| const schema = data.overwrite | ||
| ? blocksConfig[data['@type']].blockSchema({ intl }) | ||
| : blocksConfig[data['@type']].enhancedSchema({ intl }); |
There was a problem hiding this comment.
How about if instead of a new schema we make that check in existing one since by default its using the override schema(enhanced schema). Something like fields: ['href,' 'overwrite', data.overwrite && ('preview_image, description,...)]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PLIP: #6023
Depends on PR for plone.restapi: plone/plone.restapi#1788
Replaces #4790