Id widget refactor #6027
Id widget refactor #6027
Conversation
✅ Deploy Preview for plone-components canceled.
|
❌ Deploy Preview for volto failed. Why did it fail? →
|
|
@sneridagh It's not immediately obvious to me why the storybook build in the generator test is failing |
|
Should we be using yarn or pnpm to build the storybook? This one uses yarn, whereas we use pnpm for Volto docs when invoked by |
|
@stevepiercy At present, we expect development of volto itself to be done using pnpm, but we still expect yarn for projects built by the volto generator, which is what that test is checking. (On the other hand, the new cookiecutter for volto projects sets up a project using pnpm.) |
|
Linkcheck fails because https://www.lanku.eus/ is not reachable. Site is by CodeSyntax, so @erral? I also sent an email to their info@ email. |
|
@davisagli let's see if it still fails, after updating with |
|
@stevepiercy Well, I assume so, since I updated it within the past hour and only merged one other unrelated PR since then. |
|
@davisagli does this error mean anything to you? I don't have a clue, and my DuckDuckFu does not lead me anywhere useful. |
|
@stevepiercy No, it doesn't. That's why I asked @sneridagh about it above. |
site is up again! |
|
@davisagli LOL they're all green now, even though nothing really changed after @Tishasoumya-02 merged I found this possible solution: yarn cache cleanIt appears that we use cache in our GitHub Actions, but I don't know whether that is related. For our future selves, we can clear caches from GitHub Workflows, if something totally inexplicable with GitHub Actions recurs again. Reference: https://stackoverflow.com/a/64819132/2214933 |
* main: (60 commits) Object browser icon view v2 (#6054) Refactor TextWidget (#6020) [client] Remove the custom runner with bare vitest config (#6056) [client] Fix login mutation (#6053) Fix test script in monorepo root (#6051) Fix block chooser search is not focusable when clicked on add button (#5867) [@plone/types] BlockExtension as Interface types (#6049) Fixed querystring search query type (#6034) Id widget refactor (#6027) Release 18.0.0-alpha.32 Release @plone/providers 1.0.0-alpha.1 Release @plone/components 2.0.0-alpha.9 Release @plone/client 1.0.0-alpha.15 Release @plone/types 1.0.0-alpha.13 Fix @plone/client deps (#6045) Allow X-Robots-Tag header in images/files middleware (#6043) Fixed showRestricted not applying when rendering a custom BlocksForm (#6026) change relative import to alias import (#6041) Build documentation and Storybook only when their files change (#6037) Use pnpm corepack instead of installing it in CI (#6038) ...
#4460