Github actions improvements #6108
Conversation
|
@FritzHoing you need to sign the Plone Contributor Agreement to merge this pull request. Learn about the Plone Contributor Agreement: https://plone.org/foundation/contributors-agreement |
✅ Deploy Preview for plone-components canceled.
|
FritzHoing
changed the title
|
@FritzHoing this is a super useful contribution, but we can't accept it until you sign the Plone Contributor Agreement. This PR should also have a change log entry. Would you please take the necessary steps? Thank you! |
|
@FritzHoing you need to sign the Plone Contributor Agreement to merge this pull request. Learn about the Plone Contributor Agreement: https://plone.org/foundation/contributors-agreement |
|
Thank you very much for your feedback! I signed the Contributor Agreement on monday already and just need to wait for the approval. The changelog entry is now added in the hope that the type is set correct for ci improvements. |
|
@FritzHoing looks great! Thanks a lot for your contribution! /cc @ericof |
|
@FritzHoing I just allowed the tests to run, could you please take a look? It seems something is missing. |
There was a problem hiding this comment.
I've commited the changes necessary to get the actions to work, tested and working.
I actually added a new pull request with the changes from this pull request plus my fixes but then I did the extra work to get commit suggestions which can commit to the parent as such I will close #6120
| key: ${{ runner.os }}-pnpm-store-${{ hashFiles('**/pnpm-lock.yaml') }} | ||
| restore-keys: | | ||
| ${{ runner.os }}-pnpm-store- | ||
| - uses: actions/checkout@v4 |
There was a problem hiding this comment.
This is duplicated at line 14.
| - uses: actions/checkout@v4 |
| node-version: ${{ inputs.node-version }} | ||
|
|
||
| - name: Enable corepack | ||
| shell: bash |
There was a problem hiding this comment.
Is this necessary now? It wasn't there before. It makes sense to specify the shell when you need something that the shell provides, but not to just run a binary, as in this context.
| restore-keys: | | ||
| ${{ runner.os }}-pnpm-store- | ||
|
|
||
| - name: Install dependencies |
There was a problem hiding this comment.
Install dependencies was previously after Cache Cypress Binary. Does that matter, or affect performance?
| @@ -0,0 +1 @@ | |||
| Improved the existing GitHub workflows by encapsulating a common operation into a reusable action for easier maintenance. @FritzHoing | |||
There was a problem hiding this comment.
| Improved the existing GitHub workflows by encapsulating a common operation into a reusable action for easier maintenance. @FritzHoing | |
| Improved the existing GitHub workflows by encapsulating a common operation into a reusable action for easier maintenance. @FritzHoing, @ichim-david |
|
|
||
| - name: Install Cypress if not in cache | ||
| if: steps.cache-cypress-binary.outputs.cache-hit != 'true' | ||
| shell: bash |
There was a problem hiding this comment.
Another possibly unnecessary shell: bash?
|
I made a branch out of the changes native to the volto repo in this pull request #6120 |
|
Closing this pull request in favor of #6120 since having the pull request within Volto repo makes it easier to make changes as needed. |
This pull-request improves the existing github-workflows:
📚 Documentation preview 📚: https://volto--6108.org.readthedocs.build/