Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revisão do Tema #193

Merged
merged 13 commits into from
Jul 30, 2018
Merged

Revisão do Tema #193

merged 13 commits into from
Jul 30, 2018

Conversation

agnogueira
Copy link
Member

Revisão visual do tema para a finalização do projeto

Copy link
Member

@rodfersou rodfersou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

@accesslint accesslint bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are accessibility issues in these changes.

<h2>O que você está procurando?</h2>
<form>
<div class="LSBox">
<input name="SearchableText" type="text" size="18" title="Buscar no Site" placeholder="Buscar no Site" accesskey="4" class="searchField" id="searchGadget" autocomplete="off"><input class="searchButton" type="submit" value="Buscar">
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like there's a label missing for this input. That makes it hard for people using screen readers or voice control to use the input. If you don't want a visual label, try an aria-label attribute.

@rodfersou
Copy link
Member

@agnogueira fiz o rebase aqui, aguardando para mesclar

@hvelarde hvelarde merged commit 6f38248 into master Jul 30, 2018
@hvelarde hvelarde deleted the finalizacao-estilos branch July 30, 2018 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants