Skip to content

Commit

Permalink
Added - persistent to setup requires
Browse files Browse the repository at this point in the history
  • Loading branch information
Ben Cole committed Nov 26, 2014
1 parent 238eced commit 7f215f6
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions setup.py
View file
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,7 @@ def read(*rnames):
'zope.interface',
'zope.component',
'rwproperty',
'persistent',
],
extras_require={
'test': [
Expand Down

2 comments on commit 7f215f6

@do3cc
Copy link
Contributor

@do3cc do3cc commented on 7f215f6 Nov 27, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This creates a very interesting failure in jenkins:

Running ploneintranet.suite.testing.PLONEINTRANET_SUITE_INTEGRATION tests:
  Set up plone.testing.zca.LayerCleanup in 0.000 seconds.
  Set up plone.testing.z2.Startup Traceback (most recent call last):
  File "/var/lib/jenkins/ploneintranet.suite/buildout-cache/eggs/zope.testrunner-4.1.1-py2.7.egg/zope/testrunner/runner.py", line 380, in run_layer
    setup_layer(options, layer, setup_layers)
  File "/var/lib/jenkins/ploneintranet.suite/buildout-cache/eggs/zope.testrunner-4.1.1-py2.7.egg/zope/testrunner/runner.py", line 667, in setup_layer
    setup_layer(options, base, setup_layers)
  File "/var/lib/jenkins/ploneintranet.suite/buildout-cache/eggs/zope.testrunner-4.1.1-py2.7.egg/zope/testrunner/runner.py", line 667, in setup_layer
    setup_layer(options, base, setup_layers)
  File "/var/lib/jenkins/ploneintranet.suite/buildout-cache/eggs/zope.testrunner-4.1.1-py2.7.egg/zope/testrunner/runner.py", line 667, in setup_layer
    setup_layer(options, base, setup_layers)
  File "/var/lib/jenkins/ploneintranet.suite/buildout-cache/eggs/zope.testrunner-4.1.1-py2.7.egg/zope/testrunner/runner.py", line 672, in setup_layer
    layer.setUp()
  File "/var/lib/jenkins/ploneintranet.suite/buildout-cache/eggs/plone.testing-4.0.12-py2.7.egg/plone/testing/z2.py", line 300, in setUp
    self.setUpApp()
  File "/var/lib/jenkins/ploneintranet.suite/buildout-cache/eggs/plone.testing-4.0.12-py2.7.egg/plone/testing/z2.py", line 555, in setUpApp
    Zope2.startup()
  File "/var/lib/jenkins/ploneintranet.suite/buildout-cache/eggs/Zope2-2.13.22-py2.7.egg/Zope2/__init__.py", line 47, in startup
    _startup()
  File "/var/lib/jenkins/ploneintranet.suite/buildout-cache/eggs/Zope2-2.13.22-py2.7.egg/Zope2/App/startup.py", line 123, in startup
    DB, 'Application', OFS.Application.Application, ()
  File "/var/lib/jenkins/ploneintranet.suite/buildout-cache/eggs/Zope2-2.13.22-py2.7.egg/App/ZApplication.py", line 31, in __init__
    if not root.has_key(name):
  File "/var/lib/jenkins/ploneintranet.suite/buildout-cache/eggs/ZODB3-3.10.5-py2.7-linux-x86_64.egg/ZODB/Connection.py", line 860, in setstate
    self._setstate(obj)
  File "/var/lib/jenkins/ploneintranet.suite/buildout-cache/eggs/ZODB3-3.10.5-py2.7-linux-x86_64.egg/ZODB/Connection.py", line 915, in _setstate
    obj._p_serial = serial
ValueError: _p_serial must be an 8-character bytes array

It turned out that the persistent version pinned in Plone 5 too, seems to wrap its string twice, causing the exception. It is pretty weird because it does not happen on tests in persistent. Unfortunately I have to stop debugging here for now until at least thursday.

@do3cc
Copy link
Contributor

@do3cc do3cc commented on 7f215f6 Nov 27, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

More background, I think it is a bug in persistent zopefoundation/persistent@db732a8#commitcomment-8753169

Please sign in to comment.