-
Notifications
You must be signed in to change notification settings - Fork 27
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Aim for consistent repr of timestamp between C and Python impl.
- Loading branch information
Showing
2 changed files
with
2 additions
and
3 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
db732a8
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this introduced a bug, or maybe the c version was not got already.
self._raw already is a string. So repr(self._raw) returns a double quoted string.
I stumbled over this in plone, my comment on it has a traceback that ends with
ValueError: _p_serial must be an 8-character bytes array
ploneintranet/ploneintranet.todo@7f215f6#commitcomment-8752965
What do you think?
db732a8
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Using persistent 4.0.3 which does not contain this change, solves the problem for me.
db732a8
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@do3cc, can you file a bug so this doesn't get lost in commit comments?
db732a8
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here it is: #12
db732a8
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!