Changes plot example to use duckdb, adds installation instructions #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edublancas
requested changes
Sep 28, 2022
doc/duckdb.md
Outdated
| @@ -51,7 +52,9 @@ if not Path('my.db').is_file(): | |||
| urllib.request.urlretrieve(url, 'my.db') | |||
| ``` | |||
|
|
|||
| We'll use `sqlite_scanner` extension to load a sample SQLite databse into DuckDB: | |||
| Please note that `duckdb` dependencies need to be installed. You can install the dependencies with `pip install duckdb duckdb-engine pyarrow` from your terminal or `!pip install duckdb duckdb-engine pyarrow` from this notebook. | |||
|
|
|||
There was a problem hiding this comment.
can you add the pip instructions in a dropdown, just like we did in the duck example?
```{dropdown} Required packages
pip install duckdb duckdb-engine pyarrow
```
edublancas
approved these changes
Sep 28, 2022
|
🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've changed the example to use duckdb and added some instructions to install dependencies.
Solves problems in #8