Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed cloud tests workflow #982

Merged
merged 2 commits into from
Jan 25, 2024
Merged

Removed cloud tests workflow #982

merged 2 commits into from
Jan 25, 2024

Conversation

neelasha23
Copy link

@neelasha23 neelasha23 commented Jan 20, 2024 •
edited
Loading

Describe your changes

Related to issue #983
This fixes the SqlAlchemy v1 CI.
Removes Snowflake and Redshift workflow.

Issue number

Closes #984

Checklist before requesting a review

📚 Documentation preview 📚: https://jupysql--982.org.readthedocs.build/en/982/

@neelasha23 neelasha23 changed the title changelog test Jan 20, 2024
@neelasha23 neelasha23 added the no-changelog This PR doesn't require a changelog entry label Jan 21, 2024
@neelasha23 neelasha23 changed the title test Pin Pandas version Jan 21, 2024
@neelasha23 neelasha23 marked this pull request as ready for review January 21, 2024 07:47
@neelasha23
Copy link
Author

neelasha23 commented Jan 21, 2024 •
edited
Loading

@edublancas Was there any changes in the Snowflake server credentials or URL for test?

@edublancas
Copy link

@neelasha23 we ran some commands to give @bryannho permission to access snowflake but we didn't change other accounts (at least not on purpose).

do you have permissions to change your password? if so, try resetting it

@neelasha23
Copy link
Author

neelasha23 commented Jan 22, 2024 •
edited
Loading

do you have permissions to change your password? if so, try resetting it

Not my password, the one used for CI configured in Git. The tests are failing because of some invalid credentials: https://github.com/ploomber/jupysql/actions/runs/7599764897/job/20697285387?pr=982

FAILED src/tests/integration/test_generic_db_operations.py::test_query_snippet_invalid_function_error_message[with-typo-Snowflake] - sqlalchemy.exc.DatabaseError: (snowflake.connector.errors.DatabaseError) 250001 (08001): Failed to connect to DB: lpb17716.us-east-1.snowflakecomputing.com:443. Incorrect username or password was specified.
(Background on this error at: https://sqlalche.me/e/14/4xp6)
FAILED src/tests/integration/test_generic_db_operations.py::test_persist_in_schema[ip_with_Snowflake---no-index] - sqlalchemy.exc.DatabaseError: (snowflake.connector.errors.DatabaseError) 250001 (08001): Failed to connect to DB: lpb17716.us-east-1.snowflakecomputing.com:443. Incorrect username or password was specified.

@edublancas

@edublancas edublancas mentioned this pull request Jan 24, 2024
Closed
@bryannho bryannho mentioned this pull request Jan 24, 2024
Merged
4 tasks
@neelasha23 neelasha23 added the allow-workflow-edits Allow edits to .github/workflows label Jan 24, 2024
neelasha23
neelasha23 commented Jan 24, 2024
View reviewed changes
noxfile.py
_install(session, integration=True)
session.install(
"snowflake-sqlalchemy",
"redshift-connector",
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't removed the snowflake or redhsift connectors because the sqlalchemy version is getting messed up. Installing version 1 explicitly is not helping either. I don't have an answer why, maybe we can handle it in a separate PR.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

weird, ok. please open a separate PR.

@neelasha23 neelasha23 changed the title Pin Pandas version Removed cloud tests workflow Jan 24, 2024
@neelasha23
Copy link
Author

Please review @edublancas

edublancas
edublancas requested changes Jan 24, 2024
View reviewed changes
.github/workflows/ci-integration-db-sqlalchemy-v1.yaml Show resolved Hide resolved
doc/community/developer-guide.md Outdated Show resolved Hide resolved
noxfile.py
_install(session, integration=True)
session.install(
"snowflake-sqlalchemy",
"redshift-connector",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

weird, ok. please open a separate PR.

noxfile.py Show resolved Hide resolved
setup.py Show resolved Hide resolved
@neelasha23
Remove cloud tests workflow
942fc15 
changelog

Empty

sqlalchemy v1

pandas version

removed live workflow

clickhouse workflow

rename func

fix

fix

fix

fix

fix

check ex

clickhouse

install sqlalchemy

v1

v1

docs modified

comment

docs fix

comment

typo
@neelasha23
Copy link
Author

Addressed the comments @edublancas

@edublancas edublancas merged commit aaf4021 into master Jan 25, 2024
22 of 23 checks passed
@edublancas edublancas deleted the test branch January 25, 2024 00:26
This was referenced Jan 25, 2024
Closed
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edublancas edublancas Awaiting requested review from edublancas edublancas is a code owner

Assignees
No one assigned
Labels
allow-workflow-edits Allow edits to .github/workflows no-changelog This PR doesn't require a changelog entry
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

remove snowflake and redshift issues
2 participants
@neelasha23 @edublancas