Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 1.2.0 #185

Merged
merged 21 commits into from
Feb 7, 2023
Merged

Release 1.2.0 #185

merged 21 commits into from
Feb 7, 2023

Conversation

etpinard
Copy link
Collaborator

@etpinard etpinard commented Feb 6, 2023

using #169 as guide


Release 1.2.0

etpinard and others added 17 commits November 28, 2022 17:48
to run the Julia `] test`
on multiple Julia versions.
to match PlotlyBase compat
unti #177 is addressed
to match the compat of `PlotlyBase.jl` (one of our deps)
the operational one is in `.github/workflows/`
for `HTTP.serve`, the verbose HTTP
logs are too much for Dash.jl users
even while debugging.
The `verbose` default is `false`,
so we can drop it.
Bump HTTP compat to "1", drop support for Julia versions below 1.6
@github-actions github-actions bot added CI documentation Improvements or additions to documentation enhancement New feature or request tests labels Feb 6, 2023
@etpinard
Copy link
Collaborator Author

etpinard commented Feb 6, 2023

Oh, at least 1 approving review is required by reviewers with write access

Asking @alexcjohnson - thank you in advance!

@alexcjohnson
Copy link
Contributor

@etpinard I could rubber-stamp this, but perhaps it's worth asking @waralexrom if he has any comments?

The only thing I notice - in the spirit of consistency and minimizing unnecessary diffs - is that some hard tab characters appear in the code now, whereas previously it looks like all 4-space tabs.

Copy link
Collaborator

@waralexrom waralexrom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @etpinard!
Thank you so much for joining the development of the Dash.jl, unfortunately I didn't have time for it at all :(
The PR looks good for me 👍 💃

Copy link
Contributor

@alexcjohnson alexcjohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @waralexrom!
And @etpinard thanks for reindenting 🎉
💃

@etpinard etpinard merged commit e8344fb into master Feb 7, 2023
@etpinard
Copy link
Collaborator Author

etpinard commented Feb 7, 2023

@JuliaRegistrator register

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI documentation Improvements or additions to documentation enhancement New feature or request tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants